2010-01-19  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by NOBODY (OOPS!).

        Some window properties are not returned by Object.keys and Object.getOwnPropertyNames

        https://bugs.webkit.org/show_bug.cgi?id=33603

        Add test for checking that properties on the Window prototype are proxied by the Window object.

        * fast/dom/Window/script-tests/window-property-proxying.js: Added.

        * fast/dom/Window/window-property-proxying-expected.txt: Added.

        * fast/dom/Window/window-property-proxying.html: Added.

description(

"This test checks that properties on the Window prototype are proxied by the Window object."

);

var windowKeys = Object.keys(window);

var windowOwnPropertyNames = Object.getOwnPropertyNames(window);

var protoPropertyNamesSet = {};

for (var o = window.__proto__; o; o = o.__proto__) {

    var names = Object.getOwnPropertyNames(o);

    for (var i = 0; i < names.length; ++i)

        protoPropertyNamesSet[names[i]] = true;

}

for (var name in protoPropertyNamesSet) {

    shouldBeTrue("window.hasOwnProperty('" + name + "')");

    shouldBeEqualToString("typeof Object.getOwnPropertyDescriptor(window, '" + name + "')", "object");

    shouldBeTrue("windowOwnPropertyNames.indexOf('" + name + "') != -1");

    if (window.propertyIsEnumerable(name))

        shouldBeTrue("windowKeys.indexOf('" + name + "') != -1");

    shouldBe("window['" + name + "']", "window.__proto__['" + name + "']");

}

var successfullyParsed = true;

This test checks that properties on the Window prototype are proxied by the Window object.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS window.hasOwnProperty('moveBy') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'moveBy') is "object"

PASS windowOwnPropertyNames.indexOf('moveBy') != -1 is true

PASS windowKeys.indexOf('moveBy') != -1 is true

PASS window['moveBy'] is window.__proto__['moveBy']

PASS window.hasOwnProperty('find') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'find') is "object"

PASS windowOwnPropertyNames.indexOf('find') != -1 is true

PASS windowKeys.indexOf('find') != -1 is true

PASS window['find'] is window.__proto__['find']

PASS window.hasOwnProperty('resizeTo') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'resizeTo') is "object"

PASS windowOwnPropertyNames.indexOf('resizeTo') != -1 is true

PASS windowKeys.indexOf('resizeTo') != -1 is true

PASS window['resizeTo'] is window.__proto__['resizeTo']

PASS window.hasOwnProperty('clearTimeout') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'clearTimeout') is "object"

PASS windowOwnPropertyNames.indexOf('clearTimeout') != -1 is true

PASS windowKeys.indexOf('clearTimeout') != -1 is true

PASS window['clearTimeout'] is window.__proto__['clearTimeout']

PASS window.hasOwnProperty('btoa') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'btoa') is "object"

PASS windowOwnPropertyNames.indexOf('btoa') != -1 is true

PASS windowKeys.indexOf('btoa') != -1 is true

PASS window['btoa'] is window.__proto__['btoa']

PASS window.hasOwnProperty('getComputedStyle') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'getComputedStyle') is "object"

PASS windowOwnPropertyNames.indexOf('getComputedStyle') != -1 is true

PASS windowKeys.indexOf('getComputedStyle') != -1 is true

PASS window['getComputedStyle'] is window.__proto__['getComputedStyle']

PASS window.hasOwnProperty('setTimeout') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'setTimeout') is "object"

PASS windowOwnPropertyNames.indexOf('setTimeout') != -1 is true

PASS windowKeys.indexOf('setTimeout') != -1 is true

PASS window['setTimeout'] is window.__proto__['setTimeout']

PASS window.hasOwnProperty('scrollBy') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'scrollBy') is "object"

PASS windowOwnPropertyNames.indexOf('scrollBy') != -1 is true

PASS windowKeys.indexOf('scrollBy') != -1 is true

PASS window['scrollBy'] is window.__proto__['scrollBy']

PASS window.hasOwnProperty('print') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'print') is "object"

PASS windowOwnPropertyNames.indexOf('print') != -1 is true

PASS windowKeys.indexOf('print') != -1 is true

PASS window['print'] is window.__proto__['print']

PASS window.hasOwnProperty('resizeBy') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'resizeBy') is "object"

PASS windowOwnPropertyNames.indexOf('resizeBy') != -1 is true

PASS windowKeys.indexOf('resizeBy') != -1 is true

PASS window['resizeBy'] is window.__proto__['resizeBy']

PASS window.hasOwnProperty('atob') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'atob') is "object"

PASS windowOwnPropertyNames.indexOf('atob') != -1 is true

PASS windowKeys.indexOf('atob') != -1 is true

PASS window['atob'] is window.__proto__['atob']

PASS window.hasOwnProperty('openDatabase') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'openDatabase') is "object"

PASS windowOwnPropertyNames.indexOf('openDatabase') != -1 is true

PASS windowKeys.indexOf('openDatabase') != -1 is true

PASS window['openDatabase'] is window.__proto__['openDatabase']

PASS window.hasOwnProperty('moveTo') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'moveTo') is "object"

PASS windowOwnPropertyNames.indexOf('moveTo') != -1 is true

PASS windowKeys.indexOf('moveTo') != -1 is true

PASS window['moveTo'] is window.__proto__['moveTo']

PASS window.hasOwnProperty('scroll') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'scroll') is "object"

PASS windowOwnPropertyNames.indexOf('scroll') != -1 is true

PASS windowKeys.indexOf('scroll') != -1 is true

PASS window['scroll'] is window.__proto__['scroll']

PASS window.hasOwnProperty('confirm') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'confirm') is "object"

PASS windowOwnPropertyNames.indexOf('confirm') != -1 is true

PASS windowKeys.indexOf('confirm') != -1 is true

PASS window['confirm'] is window.__proto__['confirm']

PASS window.hasOwnProperty('getMatchedCSSRules') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'getMatchedCSSRules') is "object"

PASS windowOwnPropertyNames.indexOf('getMatchedCSSRules') != -1 is true

PASS windowKeys.indexOf('getMatchedCSSRules') != -1 is true

PASS window['getMatchedCSSRules'] is window.__proto__['getMatchedCSSRules']

PASS window.hasOwnProperty('showModalDialog') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'showModalDialog') is "object"

PASS windowOwnPropertyNames.indexOf('showModalDialog') != -1 is true

FAIL window['showModalDialog'] should be function showModalDialog() {

    [native code]

} (of type function). Was undefined (of type undefined).

PASS window.hasOwnProperty('close') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'close') is "object"

PASS windowOwnPropertyNames.indexOf('close') != -1 is true

PASS windowKeys.indexOf('close') != -1 is true

PASS window['close'] is window.__proto__['close']

PASS window.hasOwnProperty('clearInterval') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'clearInterval') is "object"

PASS windowOwnPropertyNames.indexOf('clearInterval') != -1 is true

PASS windowKeys.indexOf('clearInterval') != -1 is true

PASS window['clearInterval'] is window.__proto__['clearInterval']

PASS window.hasOwnProperty('webkitConvertPointFromNodeToPage') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'webkitConvertPointFromNodeToPage') is "object"

PASS windowOwnPropertyNames.indexOf('webkitConvertPointFromNodeToPage') != -1 is true

PASS windowKeys.indexOf('webkitConvertPointFromNodeToPage') != -1 is true

PASS window['webkitConvertPointFromNodeToPage'] is window.__proto__['webkitConvertPointFromNodeToPage']

PASS window.hasOwnProperty('open') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'open') is "object"

PASS windowOwnPropertyNames.indexOf('open') != -1 is true

PASS windowKeys.indexOf('open') != -1 is true

PASS window['open'] is window.__proto__['open']

PASS window.hasOwnProperty('prompt') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'prompt') is "object"

PASS windowOwnPropertyNames.indexOf('prompt') != -1 is true

PASS windowKeys.indexOf('prompt') != -1 is true

PASS window['prompt'] is window.__proto__['prompt']

PASS window.hasOwnProperty('focus') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'focus') is "object"

PASS windowOwnPropertyNames.indexOf('focus') != -1 is true

PASS windowKeys.indexOf('focus') != -1 is true

PASS window['focus'] is window.__proto__['focus']

PASS window.hasOwnProperty('blur') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'blur') is "object"

PASS windowOwnPropertyNames.indexOf('blur') != -1 is true

PASS windowKeys.indexOf('blur') != -1 is true

PASS window['blur'] is window.__proto__['blur']

PASS window.hasOwnProperty('scrollTo') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'scrollTo') is "object"

PASS windowOwnPropertyNames.indexOf('scrollTo') != -1 is true

PASS windowKeys.indexOf('scrollTo') != -1 is true

PASS window['scrollTo'] is window.__proto__['scrollTo']

PASS window.hasOwnProperty('removeEventListener') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'removeEventListener') is "object"

PASS windowOwnPropertyNames.indexOf('removeEventListener') != -1 is true

PASS windowKeys.indexOf('removeEventListener') != -1 is true

PASS window['removeEventListener'] is window.__proto__['removeEventListener']

PASS window.hasOwnProperty('postMessage') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'postMessage') is "object"

PASS windowOwnPropertyNames.indexOf('postMessage') != -1 is true

PASS windowKeys.indexOf('postMessage') != -1 is true

PASS window['postMessage'] is window.__proto__['postMessage']

PASS window.hasOwnProperty('setInterval') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'setInterval') is "object"

PASS windowOwnPropertyNames.indexOf('setInterval') != -1 is true

PASS windowKeys.indexOf('setInterval') != -1 is true

PASS window['setInterval'] is window.__proto__['setInterval']

PASS window.hasOwnProperty('getSelection') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'getSelection') is "object"

PASS windowOwnPropertyNames.indexOf('getSelection') != -1 is true

PASS windowKeys.indexOf('getSelection') != -1 is true

PASS window['getSelection'] is window.__proto__['getSelection']

PASS window.hasOwnProperty('alert') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'alert') is "object"

PASS windowOwnPropertyNames.indexOf('alert') != -1 is true

PASS windowKeys.indexOf('alert') != -1 is true

PASS window['alert'] is window.__proto__['alert']

PASS window.hasOwnProperty('stop') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'stop') is "object"

PASS windowOwnPropertyNames.indexOf('stop') != -1 is true

PASS windowKeys.indexOf('stop') != -1 is true

PASS window['stop'] is window.__proto__['stop']

PASS window.hasOwnProperty('webkitConvertPointFromPageToNode') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'webkitConvertPointFromPageToNode') is "object"

PASS windowOwnPropertyNames.indexOf('webkitConvertPointFromPageToNode') != -1 is true

PASS windowKeys.indexOf('webkitConvertPointFromPageToNode') != -1 is true

PASS window['webkitConvertPointFromPageToNode'] is window.__proto__['webkitConvertPointFromPageToNode']

PASS window.hasOwnProperty('addEventListener') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'addEventListener') is "object"

PASS windowOwnPropertyNames.indexOf('addEventListener') != -1 is true

PASS windowKeys.indexOf('addEventListener') != -1 is true

PASS window['addEventListener'] is window.__proto__['addEventListener']

PASS window.hasOwnProperty('dispatchEvent') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'dispatchEvent') is "object"

PASS windowOwnPropertyNames.indexOf('dispatchEvent') != -1 is true

PASS windowKeys.indexOf('dispatchEvent') != -1 is true

PASS window['dispatchEvent'] is window.__proto__['dispatchEvent']

PASS window.hasOwnProperty('captureEvents') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'captureEvents') is "object"

PASS windowOwnPropertyNames.indexOf('captureEvents') != -1 is true

PASS windowKeys.indexOf('captureEvents') != -1 is true

PASS window['captureEvents'] is window.__proto__['captureEvents']

PASS window.hasOwnProperty('releaseEvents') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'releaseEvents') is "object"

PASS windowOwnPropertyNames.indexOf('releaseEvents') != -1 is true

PASS windowKeys.indexOf('releaseEvents') != -1 is true

PASS window['releaseEvents'] is window.__proto__['releaseEvents']

PASS window.hasOwnProperty('toString') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'toString') is "object"

PASS windowOwnPropertyNames.indexOf('toString') != -1 is true

PASS window['toString'] is window.__proto__['toString']

PASS window.hasOwnProperty('toLocaleString') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'toLocaleString') is "object"

PASS windowOwnPropertyNames.indexOf('toLocaleString') != -1 is true

PASS window['toLocaleString'] is window.__proto__['toLocaleString']

PASS window.hasOwnProperty('valueOf') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'valueOf') is "object"

PASS windowOwnPropertyNames.indexOf('valueOf') != -1 is true

PASS window['valueOf'] is window.__proto__['valueOf']

PASS window.hasOwnProperty('hasOwnProperty') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'hasOwnProperty') is "object"

PASS windowOwnPropertyNames.indexOf('hasOwnProperty') != -1 is true

PASS window['hasOwnProperty'] is window.__proto__['hasOwnProperty']

PASS window.hasOwnProperty('propertyIsEnumerable') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'propertyIsEnumerable') is "object"

PASS windowOwnPropertyNames.indexOf('propertyIsEnumerable') != -1 is true

PASS window['propertyIsEnumerable'] is window.__proto__['propertyIsEnumerable']

PASS window.hasOwnProperty('isPrototypeOf') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'isPrototypeOf') is "object"

PASS windowOwnPropertyNames.indexOf('isPrototypeOf') != -1 is true

PASS window['isPrototypeOf'] is window.__proto__['isPrototypeOf']

PASS window.hasOwnProperty('__defineGetter__') is true

PASS typeof Object.getOwnPropertyDescriptor(window, '__defineGetter__') is "object"

PASS windowOwnPropertyNames.indexOf('__defineGetter__') != -1 is true

PASS window['__defineGetter__'] is window.__proto__['__defineGetter__']

PASS window.hasOwnProperty('__defineSetter__') is true

PASS typeof Object.getOwnPropertyDescriptor(window, '__defineSetter__') is "object"

PASS windowOwnPropertyNames.indexOf('__defineSetter__') != -1 is true

PASS window['__defineSetter__'] is window.__proto__['__defineSetter__']

PASS window.hasOwnProperty('__lookupGetter__') is true

PASS typeof Object.getOwnPropertyDescriptor(window, '__lookupGetter__') is "object"

PASS windowOwnPropertyNames.indexOf('__lookupGetter__') != -1 is true

PASS window['__lookupGetter__'] is window.__proto__['__lookupGetter__']

PASS window.hasOwnProperty('__lookupSetter__') is true

PASS typeof Object.getOwnPropertyDescriptor(window, '__lookupSetter__') is "object"

PASS windowOwnPropertyNames.indexOf('__lookupSetter__') != -1 is true

PASS window['__lookupSetter__'] is window.__proto__['__lookupSetter__']

PASS window.hasOwnProperty('constructor') is true

PASS typeof Object.getOwnPropertyDescriptor(window, 'constructor') is "object"

PASS windowOwnPropertyNames.indexOf('constructor') != -1 is true

PASS window['constructor'] is window.__proto__['constructor']

PASS successfullyParsed is true

TEST COMPLETE

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

<html>

<head>

<link rel="stylesheet" href="../../js/resources/js-test-style.css">

<script src="../../js/resources/js-test-pre.js"></script>

</head>

<body>

<p id="description"></p>

<div id="console"></div>

<script src="script-tests/window-property-proxying.js"></script>

<script src="../../js/resources/js-test-post.js"></script>

</body>

</html>

2010-01-19  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by NOBODY (OOPS!).

        Some window properties are not returned by Object.keys and Object.getOwnPropertyNames

        https://bugs.webkit.org/show_bug.cgi?id=33603

        Since JSDOMWindow::getOwnPropertyDescriptor() looks in the prototype object,

        JSDOMWindow::getOwnPropertyNames() should include the prototype's properties.

        Test: fast/dom/Window/window-property-proxying.html

        * bindings/js/JSDOMWindowCustom.cpp:

        (WebCore::JSDOMWindow::getOwnPropertyNames):

    // Add prototype properties to match the logic of getOwnPropertyDescriptor().

    JSValue proto = prototype();

    if (proto.isObject())

        asObject(proto)->getPropertyNames(exec, propertyNames, mode);