Bug 101688

Created attachment 173188 [details] Patch

Comment on attachment 173188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173188&action=review > Source/WebKit2/ChangeLog:9 > + Add ewk_settings_offline_web_application_cache get/set APIs which are used for setting/getting of default offline web application cache enabled/disabled. > + And enable offline web application cache for WebKit2 EFL port Can I know where the caches are saved ? > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:366 > + * @return @c EINA_TRUE if the encoding detector is enabled Huk, encoding detector?

Comment on attachment 173188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173188&action=review > Source/WebKit2/ChangeLog:7 > + The following may be clearer and more correct: "Add API functions to Ewk_Settings to set / get the offline Web application cache enabled state. This setting is now enabled by default for WebKit2 EFL port." > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:353 > + * @param settings settings object to set the offline application cache ... to set the offline application cache state. "state" is missing. > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:362 > +* Returns whether the offline application cache is enabled or not. star alignment problem? > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:367 > + * @c EINA_FALSE if not or on failure "if disabled" would be better than "if not" I believe. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:189 > + Please add a test to make sure the setting is set to true by default.

(In reply to comment #2) > (From update of attachment 173188 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173188&action=review > > > Source/WebKit2/ChangeLog:9 > > + Add ewk_settings_offline_web_application_cache get/set APIs which are used for setting/getting of default offline web application cache enabled/disabled. > > + And enable offline web application cache for WebKit2 EFL port > > Can I know where the caches are saved ? The application cahce default directory is homedirectory+"/WebKitEfl/Applications" > > > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:366 > > + * @return @c EINA_TRUE if the encoding detector is enabled > > Huk, encoding detector? It's my big mistake. I'm sorry.

Comment on attachment 173188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173188&action=review >>> Source/WebKit2/ChangeLog:9 >>> + And enable offline web application cache for WebKit2 EFL port >> >> Can I know where the caches are saved ? > > The application cahce default directory is homedirectory+"/WebKitEfl/Applications" This does not sound right. We are supposed to use standard XDG paths. It is likely to be ${XDG_DATA_HOME}/WebKitEfl/Applications (otherwise, it should be fixed).

Comment on attachment 173188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173188&action=review >>>> Source/WebKit2/ChangeLog:9 >>>> + And enable offline web application cache for WebKit2 EFL port >>> >>> Can I know where the caches are saved ? >> >> The application cahce default directory is homedirectory+"/WebKitEfl/Applications" > > This does not sound right. We are supposed to use standard XDG paths. It is likely to be ${XDG_DATA_HOME}/WebKitEfl/Applications (otherwise, it should be fixed). Actually $XDG_CACHE_HOME instead of $XDG_DATA_HOME since it is a cache.

(In reply to comment #6) > (From update of attachment 173188 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173188&action=review > > >>>> Source/WebKit2/ChangeLog:9 > >>>> + And enable offline web application cache for WebKit2 EFL port > >>> > >>> Can I know where the caches are saved ? > >> > >> The application cahce default directory is homedirectory+"/WebKitEfl/Applications" > > > > This does not sound right. We are supposed to use standard XDG paths. It is likely to be ${XDG_DATA_HOME}/WebKitEfl/Applications (otherwise, it should be fixed). > > Actually $XDG_CACHE_HOME instead of $XDG_DATA_HOME since it is a cache. Yes, you're right. Actual directory can get using Webcontext::applicationCacheDirectory(). This method returns String::fromUTF8(efreet_cache_home_get()) + "/WebKitEfl/Applications"

Comment on attachment 173188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173188&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:190 > + ASSERT_TRUE(ewk_settings_offline_web_application_cache_enabled_set(settings, EINA_TRUE)); Use standard boolean type instead of EINA_TRUE > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:193 > + ASSERT_TRUE(ewk_settings_offline_web_application_cache_enabled_set(settings, EINA_FALSE)); ditto.

Created attachment 173582 [details] Patch

Comment on attachment 173582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173582&action=review > Source/WebKit2/ChangeLog:9 > + And enable offline web application cache for WebKit2 EFL port It seems to me this description is not clear. Please re-write this more clear.

Created attachment 173609 [details] Patch

Comment on attachment 173609 [details] Patch Clearing flags on attachment: 173609 Committed r134210: <http://trac.webkit.org/changeset/134210>

All reviewed patches have been landed. Closing bug.