Bug 104345

Summary: [Shadow] HTMLContentElement::getDistributedNodes() doesn't work correctly if not in document tree.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan.autocc, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 104346    
Bug Blocks: 97279    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Shinya Kawanaka
Reported 2012-12-06 23:25:50 PST
Since we're using updateLayout() for distribution, elements not in document tree cannot ensure distribution. See also Bug 104218
Attachments
Patch (6.13 KB, patch)
2012-12-11 22:21 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (6.14 KB, patch)
2012-12-12 00:24 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.18 KB, patch)
2012-12-12 17:11 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-12-11 22:21:13 PST
Created attachment 178967 [details] Patch
Shinya Kawanaka
Comment 2 2012-12-11 22:21:40 PST
This patch can be applied after Bug 104218 is resolved.
Shinya Kawanaka
Comment 3 2012-12-12 00:24:28 PST
Created attachment 178989 [details] Patch
Hajime Morrita
Comment 4 2012-12-12 15:48:29 PST
Comment on attachment 178989 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178989&action=review > LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan.html:56 > +debug('rootChild is disconnected. Now content became inactive, so it should be distributed.'); should "not" be?
Shinya Kawanaka
Comment 5 2012-12-12 16:57:03 PST
(In reply to comment #4) > (From update of attachment 178989 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178989&action=review > > > LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan.html:56 > > +debug('rootChild is disconnected. Now content became inactive, so it should be distributed.'); > > should "not" be? Sorry, I wanted to say the content element itself should be distributed. I'll update the ChangeLog anyway.
Shinya Kawanaka
Comment 6 2012-12-12 17:11:03 PST
Created attachment 179155 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-12-12 18:12:02 PST
Comment on attachment 179155 [details] Patch for landing Clearing flags on attachment: 179155 Committed r137552: <http://trac.webkit.org/changeset/137552>
WebKit Review Bot
Comment 8 2012-12-12 18:12:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.