Bug 107089

Summary:

Introduce isHTMLTextFormControlElement and toHTMLTextFormControlElement instead of toTextFormControl

Product:

WebKit

Reporter:

Shinya Kawanaka <shinyak>

Component:

DOM

Assignee:

Shinya Kawanaka <shinyak>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eric, mifenton, ojan.autocc, tkent, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

106533

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Shinya Kawanaka

Reported 2013-01-16 20:45:25 PST

This is a follow-up bug for Bug 106533. It seems no one didn't ensure Position of enclosingTextFormControl() points ShadowDOM in input or textarea. We would like to have some ASSERT or something.

Attachments
Patch (8.22 KB, patch) 2013-01-17 20:42 PST, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Patch (10.86 KB, patch) 2013-01-17 22:16 PST, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Patch (10.87 KB, patch) 2013-01-17 23:12 PST, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Shinya Kawanaka

Comment 1 2013-01-17 20:33:38 PST

toTextFormControl() returns 0 if it's not TextFormControl. I don't think this function aligns recent coding convention... It would be better to rewrite it.

Shinya Kawanaka

Comment 2 2013-01-17 20:42:42 PST

Created attachment 183360 [details] Patch

Early Warning System Bot

Comment 3 2013-01-17 20:49:09 PST

Comment on attachment 183360 [details] Patch Attachment 183360 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15943318

Early Warning System Bot

Comment 4 2013-01-17 21:46:27 PST

Comment on attachment 183360 [details] Patch Attachment 183360 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15943349

Shinya Kawanaka

Comment 5 2013-01-17 21:52:15 PST

Ah some WebKit ports uses toTextFormControl()... :-(