Bug 112004

Summary: Add USE(PLATFORM_STRATEGIES) ifdefs to StorageNamespace.cpp
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, rwlbuis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch
rwlbuis: review+
Patch for landing. none

Carlos Garcia Campos
Reported 2013-03-11 07:26:42 PDT
Platform strategies are used there without checking if PLATFORM_STRATEGIES enabled. This breaks the build of ports not using platform strategies yet.
Attachments
Patch (2.10 KB, patch)
2013-03-11 07:29 PDT, Carlos Garcia Campos 		rwlbuis: review+
DetailsFormatted DiffDiff
Patch for landing. (2.03 KB, patch)
2013-03-12 03:32 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-03-11 07:29:38 PDT
Created attachment 192466 [details] Patch
Rob Buis
Comment 2 2013-03-11 08:34:44 PDT
Comment on attachment 192466 [details] Patch LGTM.
Alexey Proskuryakov
Comment 3 2013-03-11 11:15:06 PDT
Comment on attachment 192466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192466&action=review > Source/WebCore/storage/StorageNamespace.cpp:34 > +#if USE(PLATFORM_STRATEGIES) > #include "PlatformStrategies.h" > #include "StorageStrategy.h" > +#else > +#include "StorageNamespaceImpl.h" > +#endif I think that it's best to not add ifdefs around includes, that's just unnecessary extra work.
Carlos Garcia Campos
Comment 4 2013-03-12 03:22:19 PDT
(In reply to comment #3) > (From update of attachment 192466 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=192466&action=review > > > Source/WebCore/storage/StorageNamespace.cpp:34 > > +#if USE(PLATFORM_STRATEGIES) > > #include "PlatformStrategies.h" > > #include "StorageStrategy.h" > > +#else > > +#include "StorageNamespaceImpl.h" > > +#endif > > I think that it's best to not add ifdefs around includes, that's just unnecessary extra work. You are right, PlatformStrategies.h and StorageStrategy.h already have the #if USE(PLATFORM_STRATEGIES), I'll submit a new patch.
Carlos Garcia Campos
Comment 5 2013-03-12 03:32:27 PDT
Created attachment 192694 [details] Patch for landing. Updated patch to not use the #ifdefs for the headers that don't need it.
Carlos Garcia Campos
Comment 6 2013-03-12 09:21:05 PDT
Alexey, could you confirm the new patch is ok for you?
Rob Buis
Comment 7 2013-03-18 07:07:28 PDT
Comment on attachment 192694 [details] Patch for landing. LGTM.
WebKit Review Bot
Comment 8 2013-03-18 07:29:44 PDT
Comment on attachment 192694 [details] Patch for landing. Clearing flags on attachment: 192694 Committed r146065: <http://trac.webkit.org/changeset/146065>
WebKit Review Bot
Comment 9 2013-03-18 07:29:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.