Bug 116349

Summary: [CSS Exclusions] Add CSS parsing support for image URI shape-inside and shape-outside values
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, dino, dstockwell, esprehn+autocc, glenn, macpherson, menard, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 116348    
Attachments:
Description Flags
Patch
none
Patch
achicu: review+
Patch none

Hans Muller
Reported 2013-05-17 14:00:55 PDT
Add support for parsing image URI values for the shape-inside and shape-outside CSS properties.
Attachments
Patch (16.22 KB, patch)
2013-05-17 15:02 PDT, Hans Muller 		no flags
DetailsFormatted DiffDiff
Patch (20.64 KB, patch)
2013-05-17 15:39 PDT, Hans Muller 		achicu: review+
DetailsFormatted DiffDiff
Patch (20.81 KB, patch)
2013-05-20 10:28 PDT, Hans Muller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2013-05-17 15:02:06 PDT
Created attachment 202164 [details] Patch Note: there are some test changes that I'd like to make in a subequent patch, to keep this one focused on just the mechanics of adding support for shape image URIs. The parsing shape-inside,outside parsing tests should be refactored, since they're nearly identical, and they should be moved to a subdirectory.
WebKit Commit Bot
Comment 2 2013-05-17 15:04:37 PDT
Attachment 202164 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/exclusions/parsing-wrap-shape-inside-expected.txt', u'LayoutTests/fast/exclusions/parsing-wrap-shape-outside-expected.txt', u'LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape-inside.js', u'LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape-outside.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/StyleResolver.cp