Bug 11959

Summary:

Improve layout test result display

Product:

WebKit

Reporter:

mitz

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Enhancement

CC:

aakash_jain, ahmad.saleem792, ap, ddkilzer, eric, jbedard, mrowe, ryanhaddad, sam, simon.fraser

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Mockup (very rough draft)	none
Mockup Recreated	none
Mockup (gzipped)	none

mitz

Reported 2006-12-24 13:10:21 PST

The HTML output of run-webkit-tests, used to examine test failures, can be improved in several ways. I am attaching a very crude mockup of what the display of a single test failure might look like.

Attachments
Mockup (very rough draft) (98.89 KB, application/x-webarchive) 2006-12-24 13:11 PST, mitz	no flags	Details
Mockup Recreated (113.16 KB, application/x-webarchive) 2006-12-24 13:58 PST, David Kilzer (:ddkilzer)	no flags	Details
Mockup (gzipped) (65.03 KB, application/x-gzip) 2006-12-24 14:16 PST, mitz	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2006-12-24 13:11:32 PST

Created attachment 12005 [details] Mockup (very rough draft)

mitz

Comment 2 2006-12-24 13:16:34 PST

Some notes on the mockup: the slider is intended to control an SVG filter applied to the difference image to enhance small differences (basically a linear transformation). In fact, I think it might be possible to not save the difference image as a file at all and generate it on the fly using SVG. Also, since the width is 800px, there's plenty of room for a sidebar with the list of all failing tests.

mitz

Comment 3 2006-12-24 13:19:12 PST

Oh, and while I don't find it particularly useful, the "alternate between actual and expected images" functionality could be preserved, activated say by clicking a small icon between the actual and expected tabs. It would also be nice to have the text diff colorized.

David Kilzer (:ddkilzer)

Comment 4 2006-12-24 13:55:23 PST

(In reply to comment #1) > Created an attachment (id=12005) [edit] > Mockup (very rough draft) None of the expected, actual or diff images show up when I open the .webarchive, although I've confirmed that they're all in file. Not sure why, though. If I convert the .webarchive to a "web page, complete" format, it seems to work fine.

David Kilzer (:ddkilzer)

Comment 5 2006-12-24 13:58:17 PST

Created attachment 12007 [details] Mockup Recreated Converted Attachment 12005 [details] to a "web page, complete" format using a Perl script I've been working on, then converted it back to a .webarchive. Works for me even after the "original" files have been removed.

David Kilzer (:ddkilzer)

Comment 6 2006-12-24 14:00:22 PST

(In reply to comment #4) > (In reply to comment #1) > > Created an attachment (id=12005) [edit] > > Mockup (very rough draft) > > None of the expected, actual or diff images show up when I open the > .webarchive, although I've confirmed that they're all in file. Not sure why, > though. If I convert the .webarchive to a "web page, complete" format, it > seems to work fine. This is probably a bug when reloading the .webarchive, although it would be useful to have the original sources to make it reproducible.

mitz

Comment 7 2006-12-24 14:16:36 PST

Created attachment 12008 [details] Mockup (gzipped)

Ahmad Saleem

Comment 8 2022-09-22 14:53:44 PDT

Is it something needed right now? Thanks!

Alexey Proskuryakov

Comment 9 2022-09-29 10:53:29 PDT

The diff page saw some improvements since 2006, but some of these ideas still stand. We don't have a filter to enhance small differences, and it continues to be tricky at times. And colorization would be nice too.

Note You need to log in before you can comment on or make changes to this bug.