Bug 125433

Summary: Hoist and combine array bounds checks
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, bunhere, cmarcelo, commit-queue, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, nrotem, oliver, rakuco, sam, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 125253, 125480, 125519, 128635, 128910    
Bug Blocks: 112840    
Attachments:
Description Flags
work in progress
none
almost done
none
more!!
none
the patch mhahnenberg: review+

Filip Pizlo
Reported 2013-12-08 19:54:43 PST
Patch forthcoming.
Attachments
work in progress (19.66 KB, patch)
2014-02-11 16:41 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
almost done (30.88 KB, patch)
2014-02-11 19:05 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
more!! (49.18 KB, patch)
2014-02-11 23:16 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (72.62 KB, patch)
2014-02-12 15:57 PST, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-02-11 16:41:02 PST
Created attachment 223912 [details] work in progress
Filip Pizlo
Comment 2 2014-02-11 19:05:06 PST
Created attachment 223929 [details] almost done I would test this except I'm blocked on https://bugs.webkit.org/show_bug.cgi?id=128635.
Filip Pizlo
Comment 3 2014-02-11 23:16:43 PST
Created attachment 223943 [details] more!! It successfully eliminated some overflow checks
WebKit Commit Bot
Comment 4 2014-02-12 01:09:48 PST
Attachment 223943 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGIntegerCheckHoistingPhase.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/JavaScriptCore/dfg/DFGIntegerCheckHoistingPhase.cpp:287: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGIntegerCheckHoistingPhase.cpp:310: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 3 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 5 2014-02-12 15:57:24 PST
Created attachment 224020 [details] the patch
Mark Hahnenberg
Comment 6 2014-02-12 17:08:27 PST
Comment on attachment 224020 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=224020&action=review r=me > Source/JavaScriptCore/dfg/DFGAbstractValue.cpp:77 > m_futurePossibleStructure.clear(); > m_arrayModes = 0; > } > - > + > m_type = speculationFromValue(value); > if (m_type == SpecInt52AsDouble) > m_type = SpecInt52; > m_value = value; > - > + > checkConsistency(); > } > Revert. > Source/JavaScriptCore/dfg/DFGInsertionSet.h:62 > { > return insert(Insertion(index, element)); > } > - > + > #define DFG_DEFINE_INSERT_NODE(templatePre, templatePost, typeParams, valueParamsComma, valueParams, valueArgs) \ > templatePre typeParams templatePost Node* insertNode(size_t index, SpeculatedType type valueParamsComma valueParams) \ > { \ Revert.
Filip Pizlo
Comment 7 2014-02-13 14:42:06 PST
Landed in http://trac.webkit.org/changeset/164059
Note You need to log in before you can comment on or make changes to this bug.