Bug 125649

Summary: cStack: Calling into FTL-generated code should be fast
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 113621    
Attachments:
Description Flags
starting
none
moar
none
FTL-on-C-stack now knows that 1+1=2
none
it sort of runs crypto
none
the patch ggaren: review+

Filip Pizlo
Reported 2013-12-12 13:00:52 PST
Patch forthcoming.
Attachments
starting (10.09 KB, patch)
2013-12-12 13:56 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
moar (37.05 KB, patch)
2013-12-13 14:29 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
FTL-on-C-stack now knows that 1+1=2 (43.53 KB, patch)
2013-12-13 15:13 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it sort of runs crypto (51.40 KB, patch)
2013-12-13 21:24 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (54.42 KB, patch)
2013-12-14 10:54 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-12-12 13:56:53 PST
Created attachment 219116 [details] starting
Filip Pizlo
Comment 2 2013-12-13 14:29:05 PST
Created attachment 219199 [details] moar
Filip Pizlo
Comment 3 2013-12-13 15:13:55 PST
Created attachment 219204 [details] FTL-on-C-stack now knows that 1+1=2 It ran the first program.
Filip Pizlo
Comment 4 2013-12-13 21:24:58 PST
Created attachment 219232 [details] it sort of runs crypto You have to disable the LLInt and GC, but it sort of works.
Filip Pizlo
Comment 5 2013-12-14 10:54:25 PST
Created attachment 219254 [details] the patch
Filip Pizlo
Comment 6 2013-12-14 13:35:08 PST
Landed in http://trac.webkit.org/changeset/160600
Geoffrey Garen
Comment 7 2013-12-16 12:15:26 PST
Comment on attachment 219254 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=219254&action=review r=me > Source/JavaScriptCore/runtime/Options.h:211 > + v(bool, disableGC, false) \ I prefer for settings like this to be stated in the affirmative: "enableGC", defaulting to true. "Don't disable GC" is a hard phrase to parse.
Mark Lam
Comment 8 2014-01-13 18:44:21 PST
Review status updated in r161938: <http://trac.webkit.org/r161938>.
Note You need to log in before you can comment on or make changes to this bug.