Bug 127802

Summary: [CSS Shapes] Serialize basic shape positions
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: betravis, buildbot, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 129404, 129700    
Bug Blocks: 124173    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
none
Patch none

Rob Buis
Reported 2014-01-28 14:30:14 PST
Serialize basic shape positions.
Attachments
Patch (38.13 KB, patch)
2014-01-28 14:35 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (40.42 KB, patch)
2014-01-29 08:07 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (13.06 KB, patch)
2014-01-31 14:33 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (26.48 KB, patch)
2014-02-04 11:47 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (30.96 KB, patch)
2014-02-05 08:36 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (556.00 KB, application/zip)
2014-02-05 09:18 PST, Build Bot 		no flags
Details
Patch (21.50 KB, patch)
2014-02-05 11:28 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2014-01-28 14:35:50 PST
Created attachment 222494 [details] Patch
Rob Buis
Comment 2 2014-01-29 08:07:18 PST
Created attachment 222573 [details] Patch
Dean Jackson
Comment 3 2014-01-30 21:52:45 PST
Comment on attachment 222573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222573&action=review > Source/WebCore/ChangeLog:8 > + Serialize basic shape positions by trying to detect keywords and trying to be as close as possible to the original input. Nit: extra whitespace char in indentation. > Source/WebCore/ChangeLog:11 > + * css/BasicShapeFunctions.cpp: > + (WebCore::valueForCenterCoordinate): Could you describe what you did here?
Rob Buis
Comment 4 2014-01-31 13:34:40 PST
(In reply to comment #3) > (From update of attachment 222573 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222573&action=review > > > Source/WebCore/ChangeLog:8 > > + Serialize basic shape positions by trying to detect keywords and trying to be as close as possible to the original input. > > Nit: extra whitespace char in indentation. Oops, will fix. > > Source/WebCore/ChangeLog:11 > > + * css/BasicShapeFunctions.cpp: > > + (WebCore::valueForCenterCoordinate): > > Could you describe what you did here? Will try to... So thanks for the review, but I'll have to change the patch slightly since the spec for this changed earlier this week :) New patch coming up...
Rob Buis
Comment 5 2014-01-31 14:33:13 PST
Created attachment 222853 [details] Patch
Rob Buis
Comment 6 2014-01-31 15:05:15 PST
Comment on attachment 222853 [details] Patch From the feedback I got this is the right way to go. However there are some more tests possible to add so I'll remove the review flag for now.
Rob Buis
Comment 7 2014-02-04 11:47:08 PST
Created attachment 223149 [details] Patch
Rob Buis
Comment 8 2014-02-05 08:36:23 PST
Created attachment 223240 [details] Patch
Build Bot
Comment 9 2014-02-05 09:18:16 PST
Comment on attachment 223240 [details] Patch Attachment 223240 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5596259373023232 New failing tests: svg/transforms/transform-origin-css-property.xhtml
Build Bot
Comment 10 2014-02-05 09:18:18 PST
Created attachment 223244 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Rob Buis
Comment 11 2014-02-05 11:28:13 PST
Created attachment 223250 [details] Patch
Bear Travis
Comment 12 2014-02-26 15:20:48 PST
I will be taking a look at this.
Rob Buis
Comment 13 2014-02-27 13:33:04 PST
Comment on attachment 223250 [details] Patch Clearing review flag, Bear is taking over.
Bear Travis
Comment 14 2014-03-07 15:39:53 PST
Closing, as the two dependent issues have been fixed.
Note You need to log in before you can comment on or make changes to this bug.