Bug 142393

Summary: [GTK] basic OpenWebRTC build support
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adam.bergkvist, cgarcia, mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79203, 143211, 142476    
Attachments:
Description Flags
patch
none
patch
none
patch
none
patch
none
patch
none
patch
none
patch
none
patch cgarcia: review+

Philippe Normand
Reported 2015-03-06 06:13:38 PST
As a first step towards integration of OpenWebRTC on the platform layer it'd be good to add it in JHBuild and CMake stuff.
Attachments
patch (7.89 KB, patch)
2015-03-06 07:16 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
patch (8.33 KB, patch)
2015-03-09 02:30 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
patch (8.58 KB, patch)
2015-03-12 09:39 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
patch (8.58 KB, patch)
2015-03-12 09:49 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
patch (8.51 KB, patch)
2015-03-16 03:28 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
patch (8.51 KB, patch)
2015-03-16 04:00 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
patch (8.51 KB, patch)
2015-03-16 04:51 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
patch (8.55 KB, patch)
2015-03-16 05:50 PDT, Philippe Normand 		cgarcia: review+
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2015-03-06 06:30:23 PST
We will need to make sure MEDIA_STREAM build is disabled in the release tarballs for now because the mediastream audio/video rendering module will depend on a non-upstream version of OpenWebRTC. However I think this feature should remain enabled in developer builds and on the buildbots :)
Philippe Normand
Comment 2 2015-03-06 07:16:22 PST
Created attachment 248064 [details] patch
Carlos Garcia Campos
Comment 3 2015-03-06 08:35:08 PST
It seems gst-plugins-openwebrtc failed to build for whatever reason. Btw, I'm not happy using downstream forks as dependencies (I prefer to use upstream repos and add the patches required by WebKit), but I guess this is a temporary thing.
Philippe Normand
Comment 4 2015-03-09 00:54:46 PDT
Of course it is temporary. I'll try to figure out what's up with the EWS.
Philippe Normand
Comment 5 2015-03-09 02:30:24 PDT
Created attachment 248235 [details] patch
Philippe Normand
Comment 6 2015-03-12 09:39:13 PDT
Created attachment 248520 [details] patch
Philippe Normand
Comment 7 2015-03-12 09:49:05 PDT
Created attachment 248521 [details] patch
Philippe Normand
Comment 8 2015-03-16 03:28:24 PDT
Created attachment 248717 [details] patch
Philippe Normand
Comment 9 2015-03-16 04:00:15 PDT
Created attachment 248719 [details] patch EWS all over again
Philippe Normand
Comment 10 2015-03-16 04:51:41 PDT
Created attachment 248720 [details] patch lalala
Philippe Normand
Comment 11 2015-03-16 05:50:06 PDT
Created attachment 248723 [details] patch
Philippe Normand
Comment 12 2015-03-16 07:13:06 PDT
Green EWS is green. Can this be reviewed now? :)
Carlos Garcia Campos
Comment 13 2015-03-16 07:25:57 PDT
Comment on attachment 248723 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=248723&action=review > Tools/gtk/jhbuild.modules:384 > + <autotools id="libnice"> > + <dependencies> > + <dep package="gstreamer"/> > + </dependencies> > + <branch repo="freedesktop-git" module="libnice/libnice.git" tag="0.1.10" checkoutdir="libnice"/> > + </autotools> I guess we need this here, because the version that can be installed in the bots is not recent enough, right?
Martin Robinson
Comment 14 2015-03-16 07:48:38 PDT
(In reply to comment #13) > Comment on attachment 248723 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248723&action=review > > > Tools/gtk/jhbuild.modules:384 > > + <autotools id="libnice"> > > + <dependencies> > > + <dep package="gstreamer"/> > > + </dependencies> > > + <branch repo="freedesktop-git" module="libnice/libnice.git" tag="0.1.10" checkoutdir="libnice"/> > > + </autotools> > > I guess we need this here, because the version that can be installed in the > bots is not recent enough, right? Typically these types of dependencies go into jhbuild-optional.modules.
Philippe Normand
Comment 15 2015-03-16 07:54:19 PDT
(In reply to comment #14) > (In reply to comment #13) > > Comment on attachment 248723 [details] > > patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=248723&action=review > > > > > Tools/gtk/jhbuild.modules:384 > > > + <autotools id="libnice"> > > > + <dependencies> > > > + <dep package="gstreamer"/> > > > + </dependencies> > > > + <branch repo="freedesktop-git" module="libnice/libnice.git" tag="0.1.10" checkoutdir="libnice"/> > > > + </autotools> > > > > I guess we need this here, because the version that can be installed in the > > bots is not recent enough, right? > Right, the one I have here in Debian is 0.1.7 but configure.ac requires 0.1.7.1 or greater. > Typically these types of dependencies go into > jhbuild-optional.modules. By these you mean openwebrtc as well? I'm afraid it will be needed to run the layout tests though.
Philippe Normand
Comment 16 2015-03-17 01:40:58 PDT
Committed r181624: <http://trac.webkit.org/changeset/181624>
Note You need to log in before you can comment on or make changes to this bug.