Bug 142782

Summary: [EFL] Bump gstreamer version to 1.4.4
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, ossy, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 142778    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Csaba Osztrogonác
Reported 2015-03-17 04:55:28 PDT
It is needed for bug142778 and GTK did it in bug138866, we should use exactly the same version. I'm going to prepare the patch for it later today.
Attachments
Patch (6.59 KB, patch)
2015-03-17 08:21 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (16.35 KB, patch)
2015-03-17 08:41 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (17.11 KB, patch)
2015-03-17 09:09 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-03-17 08:21:58 PDT
Created attachment 248847 [details] Patch WIP patch, needs testing on our ARM bots too. Copy/pasted from jhbuild.modules of GTK, but leave gst-libav.patch unchanged. It seems many options are unneeded now: --enable-theora, --enable-vorbis, --enable-pulse, --enable-faad and --enable-mpg123. They are already enabled by default without explicit options, so we can match with the GTK's config.
Csaba Osztrogonác
Comment 2 2015-03-17 08:41:28 PDT
Created attachment 248848 [details] Patch really adding all files to the patch
Csaba Osztrogonác
Comment 3 2015-03-17 09:09:53 PDT
Created attachment 248851 [details] Patch resolved conflict in gst-libav.patch
Csaba Osztrogonác
Comment 4 2015-03-17 12:04:11 PDT
I tested it on our ARM bots, build is happy and tested on x86_64, build works fine and there is no layout test regression. Gyuyoung, do you agree with bumping gstreamer version?
Gyuyoung Kim
Comment 5 2015-03-17 18:53:26 PDT
(In reply to comment #4) > I tested it on our ARM bots, build is happy and tested on x86_64, > build works fine and there is no layout test regression. > > Gyuyoung, do you agree with bumping gstreamer version? Why not bumping it ? :) AFAIK, Tizen is going to support gstreamer 1.4 too.
Csaba Osztrogonác
Comment 6 2015-03-18 01:47:50 PDT
(In reply to comment #5) > (In reply to comment #4) > > I tested it on our ARM bots, build is happy and tested on x86_64, > > build works fine and there is no layout test regression. > > > > Gyuyoung, do you agree with bumping gstreamer version? > > Why not bumping it ? :) AFAIK, Tizen is going to support gstreamer 1.4 too. I just asked, because I didn't know the roadmap and plans of EFL.
WebKit Commit Bot
Comment 7 2015-03-18 02:33:19 PDT
Comment on attachment 248851 [details] Patch Clearing flags on attachment: 248851 Committed r181690: <http://trac.webkit.org/changeset/181690>
WebKit Commit Bot
Comment 8 2015-03-18 02:33:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.