Bug 147096

<rdar://problem/21892871>

Created attachment 257070 [details] Patch

Comment on attachment 257070 [details] Patch Attachment 257070 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4606950234914816 New failing tests: inspector-protocol/sync-test-suite.html

Created attachment 257072 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5

Comment on attachment 257070 [details] Patch Attachment 257070 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5118500704092160 New failing tests: inspector-protocol/sync-test-suite.html

Created attachment 257073 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Created attachment 257074 [details] PFR (fixed test result)

Comment on attachment 257074 [details] PFR (fixed test result) View in context: https://bugs.webkit.org/attachment.cgi?id=257074&action=review > LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js:200 > + result.catch(function(e) { return result.catch(...) instead of result? > LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js:324 > + if (this.forceSyncDebugLogging) > + this.debugLog(formattedMessage); > + else > + this.log(formattedMessage); This can just call log() which will handle forceSyncDebugLogging for us. > LayoutTests/inspector-protocol/runtime/getProperties.html:54 > + InspectorTest.awaitCommand({ > + method: "Runtime.evaluate", > + params: {expression} > + }) > + .then(function(reply) { > + var objectId = reply.result.objectId; > + if (objectId === undefined) > + throw new Error("objectId is expected"); > + > + return InspectorTest.awaitCommand({ > + method: "Runtime.getProperties", > + params: {objectId, ownProperties: true} > + }); > + }) > + .then(function(reply) { > + dumpGetPropertiesResult(reply); > + resolve(); > + }); If some exception is triggered inside the awaitCommand's callbacks, that doesn't appear to propagate to anything. I have a feeling, that somehow there should be an: .catch(reject) I'm not sure if you could return the chain (see below) because here we are actually calling resolve() on our own... return InspectorTest.awaitCommand(...) .then(...) .then(...); But maybe it would work if it returned Promise.resolve() instead of calling resolve(). return InspectorTest.awaitCommand(...) .then(...) .then(function() { ... return Promise.resolve() }) That seems messier though. Thoughts?

Created attachment 257140 [details] PFR (address comments)

Comment on attachment 257140 [details] PFR (address comments) r=me

Committed r187046: <http://trac.webkit.org/changeset/187046>