Bug 148037

Summary: Web Inspector: add support for running protocol-test.js tests on Windows
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bburg, bfulgham, graouts, joepeck, mattbaker, nvasilyev, ryanhaddad, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 137157, 147093    
Attachments:
Description Flags
Patch simon.fraser: review+

Blaze Burg
Reported 2015-08-14 13:17:03 PDT
We currently don't implement TestRunner::inspectorTestStubURL() for Windows, so tests that use `protocol-test.js` cannot load the stub inspector frontend into an iframe.
Attachments
Patch (1.71 KB, patch)
2015-12-23 14:28 PST, Brent Fulgham 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-14 13:17:39 PDT
<rdar://problem/22292237>
Brent Fulgham
Comment 2 2015-12-23 12:48:32 PST
This is the cause of 'fast/dom/Window/property-access-on-cached-window-after-frame-removed.html' failing on Win
Brent Fulgham
Comment 3 2015-12-23 12:49:05 PST
*** Bug 151759 has been marked as a duplicate of this bug. ***
Brent Fulgham
Comment 4 2015-12-23 14:28:19 PST
Created attachment 267856 [details] Patch
Simon Fraser (smfr)
Comment 5 2015-12-23 14:37:57 PST
Comment on attachment 267856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267856&action=review > Tools/DumpRenderTree/win/TestRunnerWin.cpp:1106 > + CFStringRef urlString = CFURLGetString(url.get()); You could lose this local variable.
Brent Fulgham
Comment 6 2015-12-23 14:40:29 PST
(In reply to comment #5) > Comment on attachment 267856 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267856&action=review > > > Tools/DumpRenderTree/win/TestRunnerWin.cpp:1106 > > + CFStringRef urlString = CFURLGetString(url.get()); > > You could lose this local variable. Oh -- good idea!
Brent Fulgham
Comment 7 2015-12-23 15:18:31 PST
Looks like this requires a clean build on Windows. :-(
Brent Fulgham
Comment 8 2015-12-23 15:25:49 PST
Committed r194398: <http://trac.webkit.org/changeset/194398>
Note You need to log in before you can comment on or make changes to this bug.