Bug 148726

Summary:

Web Inspector: combine Test.html resources to make tests run faster

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Blaze Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bburg, buildbot, commit-queue, graouts, joepeck, mattbaker, nvasilyev, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=148728

Bug Depends on:

148728

Bug Blocks:

147093

Attachments:

Description	Flags
Proposed Fix	none
Archive of layout-test-results from ews101 for mac-mavericks	none
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none
Proposed fix, no minifying	none

Blaze Burg

Reported 2015-09-02 15:14:15 PDT

Today's hypothesis is that inspector tests may be slow on low-spec bots because they have to synchronously load all of Test.html's resources individually from slow spinning hard drives. Let's try concatenating them (not minifying) to see if there's any significant difference.

Attachments
Proposed Fix (17.74 KB, patch) 2015-09-02 17:59 PDT, Blaze Burg	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-mavericks (715.54 KB, application/zip) 2015-09-02 18:20 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (782.11 KB, application/zip) 2015-09-02 18:25 PDT, Build Bot	no flags	Details
Proposed fix, no minifying (17.52 KB, patch) 2015-09-04 17:23 PDT, Blaze Burg	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-09-02 16:18:11 PDT

<rdar://problem/22548705>

Blaze Burg

Comment 2 2015-09-02 17:59:27 PDT

Created attachment 260463 [details] Proposed Fix Does not apply, depends on jsmin update and bugfix.

Build Bot

Comment 3 2015-09-02 18:20:31 PDT

Comment on attachment 260463 [details] Proposed Fix Attachment 260463 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/134765 New failing tests: inspector/dom/pseudo-element-dynamic.html inspector/css/stylesheet-events-inspector-stylesheet.html inspector/dom/setOuterHTML.html inspector/model/remote-object-fake-object.html inspector/dom/template-content.html inspector/css/stylesheet-events-basic.html inspector/dom/getOuterHTML.html inspector/css/stylesheet-events-imports.html inspector/protocol/inspector-backend-invocation-return-value.html inspector/console/command-line-api.html http/tests/inspector/dom/disconnect-dom-tree-after-main-frame-navigation.html inspector/dom/pseudo-element-static.html inspector/css/stylesheet-events-multiple-documents.html

Build Bot

Comment 4 2015-09-02 18:20:35 PDT

Created attachment 260468 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 5 2015-09-02 18:24:59 PDT

Comment on attachment 260463 [details] Proposed Fix Attachment 260463 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/134777 New failing tests: inspector/dom/pseudo-element-dynamic.html inspector/dom/template-content.html inspector/model/remote-object-fake-object.html inspector/indexeddb/requestDatabaseNames.html inspector/dom/setOuterHTML.html inspector/css/stylesheet-events-basic.html inspector/dom/getOuterHTML.html inspector/css/stylesheet-events-imports.html inspector/css/stylesheet-events-inspector-stylesheet.html inspector/protocol/inspector-backend-invocation-return-value.html inspector/console/command-line-api.html http/tests/inspector/dom/disconnect-dom-tree-after-main-frame-navigation.html inspector/dom/pseudo-element-static.html inspector/css/stylesheet-events-multiple-documents.html

Build Bot

Comment 6 2015-09-02 18:25:04 PDT

Created attachment 260469 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Timothy Hatcher

Comment 7 2015-09-03 14:49:58 PDT

Comment on attachment 260463 [details] Proposed Fix Why the Mac failures?

Blaze Burg

Comment 8 2015-09-04 09:57:35 PDT

(In reply to comment #7) > Comment on attachment 260463 [details] > Proposed Fix > > Why the Mac failures? There are diffs caused by template strings getting minified wrong. Should not be a problem when dependencies land.

Blaze Burg

Comment 9 2015-09-04 17:23:44 PDT

Created attachment 260657 [details] Proposed fix, no minifying This patch version just concats all test files together. Speed improvement was negligible (1-3s faster) on a newish imac, but might make a bigger difference on older hardware. Will test out on my fossilized macbook pro before landing.

Blaze Burg

Comment 10 2015-09-04 21:46:03 PDT

On my old machine (2009 laptop with core 2 duo and 4GB RAM, but still faster than our build bots by a lot), this reduced inspector testing time from 1m50s to 1m30s (cold start) and from 1m15s to 1m on a warmed up file cache. Let's see what happens and roll out if it makes things worse.

Timothy Hatcher

Comment 11 2015-09-04 22:24:30 PDT

SSD or hard drive?

WebKit Commit Bot

Comment 12 2015-09-04 22:29:57 PDT

Comment on attachment 260657 [details] Proposed fix, no minifying Clearing flags on attachment: 260657 Committed r189420: <http://trac.webkit.org/changeset/189420>

WebKit Commit Bot

Comment 13 2015-09-04 22:30:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.