Bug 149200

Summary: Convert return values from JavaScript functions to the expected types in WebAssembly
Product: WebKit Reporter: Sukolsak Sakshuwong <sukolsak>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mark.lam, saam, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 146064    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Update to ToT and add a link to https://bugs.webkit.org/show_bug.cgi?id=149310 none

Sukolsak Sakshuwong
Reported 2015-09-15 17:56:04 PDT
Convert return values from JavaScript functions to the expected types in WebAssembly
Attachments
Patch (23.11 KB, patch)
2015-09-15 18:03 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Patch (23.07 KB, patch)
2015-09-15 18:07 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Patch (23.02 KB, patch)
2015-09-15 18:08 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Patch (19.40 KB, patch)
2015-09-17 02:57 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Update to ToT and add a link to https://bugs.webkit.org/show_bug.cgi?id=149310 (19.65 KB, patch)
2015-09-17 16:14 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sukolsak Sakshuwong
Comment 1 2015-09-15 18:03:45 PDT
Created attachment 261274 [details] Patch
Sukolsak Sakshuwong
Comment 2 2015-09-15 18:07:28 PDT
Created attachment 261276 [details] Patch
Sukolsak Sakshuwong
Comment 3 2015-09-15 18:08:28 PDT
Created attachment 261277 [details] Patch
Sukolsak Sakshuwong
Comment 4 2015-09-17 02:57:02 PDT
Created attachment 261385 [details] Patch
Mark Lam
Comment 5 2015-09-17 10:27:25 PDT
Comment on attachment 261385 [details] Patch r=me
Saam Barati
Comment 6 2015-09-17 10:34:06 PDT
Comment on attachment 261385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261385&action=review r=me with a comment > Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:109 > + // FIXME: No need to do type conversion if the caller is a WebAssembly function. lets open a bug for this (if there isn't already one) and link it here. > Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:984 > + // FIXME: No need to do type conversion if the callee is a WebAssembly function. Let's open a bug for this if there isn't one and link it here.
Sukolsak Sakshuwong
Comment 7 2015-09-17 16:14:17 PDT
Created attachment 261449 [details] Update to ToT and add a link to https://bugs.webkit.org/show_bug.cgi?id=149310
WebKit Commit Bot
Comment 8 2015-09-17 17:04:05 PDT
Comment on attachment 261449 [details] Update to ToT and add a link to https://bugs.webkit.org/show_bug.cgi?id=149310 Clearing flags on attachment: 261449 Committed r189946: <http://trac.webkit.org/changeset/189946>
WebKit Commit Bot
Comment 9 2015-09-17 17:04:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.