Bug 149243

Summary: Make event dispatching respect slotting
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: UI EventsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eoconnor, esprehn+autocc, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 149241, 149488    
Bug Blocks: 148695    
Attachments:
Description Flags
Implements the basic dispatching
none
Patch for landing none

Ryosuke Niwa
Reported 2015-09-16 18:13:07 PDT
Make event dispatching code respect the slotting added in the bug 149241.
Attachments
Implements the basic dispatching (32.97 KB, patch)
2015-09-23 18:21 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (33.02 KB, patch)
2015-09-24 11:08 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-09-17 18:12:03 PDT
<rdar://problem/22750923>
Ryosuke Niwa
Comment 2 2015-09-19 02:14:27 PDT
*** Bug 149324 has been marked as a duplicate of this bug. ***
Ryosuke Niwa
Comment 3 2015-09-23 18:21:34 PDT
Created attachment 261857 [details] Implements the basic dispatching
Andreas Kling
Comment 4 2015-09-24 10:14:51 PDT
Comment on attachment 261857 [details] Implements the basic dispatching View in context: https://bugs.webkit.org/attachment.cgi?id=261857&action=review r=me too > Source/WebCore/dom/EventDispatcher.cpp:433 > + Node* parent; Could this be a ContainerNode*? > Source/WebCore/dom/EventDispatcher.cpp:451 > + if (auto assignedSlot = shadowRootOfParent->findAssignedSlot(*node)) { We use auto* for pointers rather than auto, I think. > Source/WebCore/dom/EventDispatcher.cpp:452 > + // node is assgined to a slot. Continue dispatching the event at this slot. Typo, assigned.
Ryosuke Niwa
Comment 5 2015-09-24 11:08:59 PDT
Created attachment 261877 [details] Patch for landing
WebKit Commit Bot
Comment 6 2015-09-24 12:00:32 PDT
Comment on attachment 261877 [details] Patch for landing Clearing flags on attachment: 261877 Committed r190214: <http://trac.webkit.org/changeset/190214>
WebKit Commit Bot
Comment 7 2015-09-24 12:00:37 PDT
All reviewed patches have been landed. Closing bug.
Brent Fulgham
Comment 8 2015-09-29 10:54:26 PDT
This change *may* have introduced Windows regressions (see https://bugs.webkit.org/show_bug.cgi?id=149632).
Note You need to log in before you can comment on or make changes to this bug.