Bug 149670

Summary: [Streams API] Update readable-stream-templated tests to latest spec
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 147092    
Bug Blocks: 149707    
Attachments:
Description Flags
Patch
none
Patch for landing none

Xabier Rodríguez Calvar
Reported 2015-09-30 09:00:58 PDT
This will break the tests because the spec has changed, but tests should come first.
Attachments
Patch (23.57 KB, patch)
2015-09-30 09:02 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch for landing (23.64 KB, patch)
2015-10-20 02:14 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2015-09-30 09:02:02 PDT
Created attachment 262166 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2015-10-14 08:12:29 PDT
Comment on attachment 262166 [details] Patch We could get a r+ and land now. The idea is getting the tests landed so that the implementation can be changed according the new spec that these tests already follow in a test driven development manner.
WebKit Commit Bot
Comment 3 2015-10-19 08:49:48 PDT
Comment on attachment 262166 [details] Patch Rejecting attachment 262166 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 262166, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: unk #2 FAILED at 20. Hunk #3 FAILED at 42. Hunk #4 succeeded at 58 with fuzz 2. Hunk #5 succeeded at 72 with fuzz 1. 2 out of 6 hunks FAILED -- saving rejects to file LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt.rej patching file LayoutTests/streams/reference-implementation/readable-stream-templated.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/307734
Xabier Rodríguez Calvar
Comment 4 2015-10-20 02:14:26 PDT
Created attachment 263560 [details] Patch for landing
WebKit Commit Bot
Comment 5 2015-10-20 03:08:16 PDT
Comment on attachment 263560 [details] Patch for landing Clearing flags on attachment: 263560 Committed r191337: <http://trac.webkit.org/changeset/191337>
WebKit Commit Bot
Comment 6 2015-10-20 03:08:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.