Bug 155300

Summary: Add shouldNotBe to standalone test harness
Product: WebKit Reporter: Andy VanWagoner <andy>
Component: New BugsAssignee: Andy VanWagoner <andy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy, rniwa, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 153679    
Attachments:
Description Flags
Patch
none
Patch none

Andy VanWagoner
Reported 2016-03-10 09:35:09 PST
Add shouldNotBe to standalone test harness
Attachments
Patch (3.55 KB, patch)
2016-03-10 09:38 PST, Andy VanWagoner 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2016-03-10 11:40 PST, Andy VanWagoner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy VanWagoner
Comment 1 2016-03-10 09:38:09 PST
Created attachment 273576 [details] Patch
Saam Barati
Comment 2 2016-03-10 11:35:03 PST
Comment on attachment 273576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273576&action=review > LayoutTests/resources/standalone-pre.js:324 > function dfgCompiled(argument) > { > var numberOfCompiles = "compiles" in argument ? argument.compiles : 1; > - > + > if (!("f" in argument)) > throw new Error("dfgCompiled called with invalid argument."); > - > + > if (argument.f instanceof Array) { > for (var i = 0; i < argument.f.length; ++i) { Please revert all whitespace changes.
Andy VanWagoner
Comment 3 2016-03-10 11:40:12 PST
Created attachment 273589 [details] Patch
Andy VanWagoner
Comment 4 2016-03-10 11:40:52 PST
(In reply to comment #2) > Comment on attachment 273576 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273576&action=review > > > LayoutTests/resources/standalone-pre.js:324 > > function dfgCompiled(argument) > > { > > var numberOfCompiles = "compiles" in argument ? argument.compiles : 1; > > - > > + > > if (!("f" in argument)) > > throw new Error("dfgCompiled called with invalid argument."); > > - > > + > > if (argument.f instanceof Array) { > > for (var i = 0; i < argument.f.length; ++i) { > > Please revert all whitespace changes. done
Ryan Haddad
Comment 5 2016-03-10 15:53:07 PST
Comment on attachment 273589 [details] Patch Marking cq+ to fix the tests.
WebKit Commit Bot
Comment 6 2016-03-10 16:42:06 PST
Comment on attachment 273589 [details] Patch Clearing flags on attachment: 273589 Committed r197969: <http://trac.webkit.org/changeset/197969>
WebKit Commit Bot
Comment 7 2016-03-10 16:42:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.