Bug 159254

Summary: WebRTC: Implement MediaEndpointPeerConnection::setConfiguration()
Product: WebKit Reporter: Adam Bergkvist <adam.bergkvist>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 143211    
Attachments:
Description Flags
Proposed patch
eric.carlson: review+
Updated patch (for landing)
buildbot: commit-queue-
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Patch for landing none

Adam Bergkvist
Reported 2016-06-29 01:17:21 PDT
MediaEndpointPeerConnection::setConfiguration() is the MediaEndpointPeerConnection implementation of RTCPeerConnection.steConfiguration() [1]. [1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcpeerconnection-setconfiguration
Attachments
Proposed patch (27.86 KB, patch)
2016-06-29 01:45 PDT, Adam Bergkvist 		eric.carlson: review+
DetailsFormatted DiffDiff
Updated patch (for landing) (27.77 KB, patch)
2016-06-29 10:29 PDT, Adam Bergkvist 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (1005.87 KB, application/zip)
2016-06-29 11:09 PDT, Build Bot 		no flags
Details
Patch for landing (27.77 KB, patch)
2016-06-29 13:15 PDT, Adam Bergkvist 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Adam Bergkvist
Comment 1 2016-06-29 01:45:50 PDT
Created attachment 282332 [details] Proposed patch
Eric Carlson
Comment 2 2016-06-29 08:23:18 PDT
Comment on attachment 282332 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=282332&action=review > Source/WebCore/platform/mediastream/PeerConnectionStates.h:32 > +#ifndef PeerConnectionStates_h > +#define PeerConnectionStates_h Nit: this can use "#pragma once"
Adam Bergkvist
Comment 3 2016-06-29 10:29:15 PDT
Created attachment 282356 [details] Updated patch (for landing)
Adam Bergkvist
Comment 4 2016-06-29 10:29:40 PDT
(In reply to comment #2) Thanks for reviewing > Comment on attachment 282332 [details] > Proposed patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282332&action=review > > > Source/WebCore/platform/mediastream/PeerConnectionStates.h:32 > > +#ifndef PeerConnectionStates_h > > +#define PeerConnectionStates_h > > Nit: this can use "#pragma once" Fixed
Build Bot
Comment 5 2016-06-29 11:09:18 PDT
Comment on attachment 282356 [details] Updated patch (for landing) Attachment 282356 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1595383 New failing tests: animations/multiple-backgrounds.html
Build Bot
Comment 6 2016-06-29 11:09:20 PDT
Created attachment 282361 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Adam Bergkvist
Comment 7 2016-06-29 13:15:20 PDT
Created attachment 282367 [details] Patch for landing
WebKit Commit Bot
Comment 8 2016-06-29 21:49:50 PDT
Comment on attachment 282367 [details] Patch for landing Clearing flags on attachment: 282367 Committed r202671: <http://trac.webkit.org/changeset/202671>
WebKit Commit Bot
Comment 9 2016-06-29 21:49:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.