Bug 175357

Summary:

Web Inspector: Make styles sidebar always LTR

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Before the patch	none
Patch for review	ews-watchlist: commit-queue-
[Image] With patch applied	none
Archive of layout-test-results from ews101 for mac-sierra	none
[Image] With patch applied 2	none
Patch for review	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none

Nikita Vasilyev

Reported 2017-08-08 16:37:19 PDT

The current version of the styles sidebar aligns text to the left. With the spreadsheet model, we can: - align text to right. - move checkboxes to the right side. - flip CSS property names and values.

Attachments
[Image] Before the patch (48.49 KB, image/png) 2018-01-09 16:38 PST, Nikita Vasilyev	no flags	Details
Patch for review (1.41 KB, patch) 2018-01-09 16:42 PST, Nikita Vasilyev	ews-watchlist: commit-queue-	Details Formatted Diff Diff
[Image] With patch applied (48.60 KB, image/png) 2018-01-09 16:42 PST, Nikita Vasilyev	no flags	Details
Archive of layout-test-results from ews101 for mac-sierra (2.56 MB, application/zip) 2018-01-09 22:30 PST, EWS Watchlist	no flags	Details
[Image] With patch applied 2 (755.17 KB, image/png) 2018-01-10 15:47 PST, Nikita Vasilyev	no flags	Details
Patch for review (1.44 KB, patch) 2018-01-10 15:48 PST, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.82 MB, application/zip) 2018-01-10 19:13 PST, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-08-08 16:37:42 PDT

<rdar://problem/33787988>

Nikita Vasilyev

Comment 2 2018-01-09 16:38:17 PST

Created attachment 330859 [details] [Image] Before the patch

Nikita Vasilyev

Comment 3 2018-01-09 16:40:11 PST

(In reply to Nikita Vasilyev from comment #0) > The current version of the styles sidebar aligns text to the left. > > With the spreadsheet model, we can: > - align text to right. > - move checkboxes to the right side. > - flip CSS property names and values. After long consideration, I don't think this makes sense to do. CSS is strictly LTR. Flipping names and values would break copy/pasting, among other things.

Nikita Vasilyev

Comment 4 2018-01-09 16:42:05 PST

Created attachment 330860 [details] Patch for review

Nikita Vasilyev

Comment 5 2018-01-09 16:42:33 PST

Created attachment 330861 [details] [Image] With patch applied

EWS Watchlist

Comment 6 2018-01-09 22:30:21 PST

Comment on attachment 330860 [details] Patch for review Attachment 330860 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6013410 New failing tests: imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-a-bitrate.html accessibility/mac/aria-multiple-liveregions-notification.html

EWS Watchlist

Comment 7 2018-01-09 22:30:23 PST

Created attachment 330882 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6

Joseph Pecoraro

Comment 8 2018-01-10 10:46:11 PST

Comment on attachment 330860 [details] Patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=330860&action=review > Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:36 > + this.element.dir = "ltr"; I think this deserves a comment. Does this section titles as well? Should it?

Nikita Vasilyev

Comment 9 2018-01-10 15:47:23 PST

Created attachment 330979 [details] [Image] With patch applied 2 (In reply to Joseph Pecoraro from comment #8) > Does this section titles as well? Should it? Does this make the section titles RTL as well?.. Is that what you asked? Yes, it does. I think it would be harder to follow the structure when only the section titles are aligned right.

Nikita Vasilyev

Comment 10 2018-01-10 15:48:52 PST

Created attachment 330980 [details] Patch for review

EWS Watchlist

Comment 11 2018-01-10 19:13:51 PST

Comment on attachment 330980 [details] Patch for review Attachment 330980 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6028516 New failing tests: webgl/1.0.2/conformance/uniforms/uniform-default-values.html

EWS Watchlist

Comment 12 2018-01-10 19:13:53 PST

Created attachment 331011 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Nikita Vasilyev

Comment 13 2018-01-11 11:12:41 PST

Comment on attachment 330980 [details] Patch for review The test failures are unrelated to the patch.

Joseph Pecoraro

Comment 14 2018-01-19 11:49:58 PST

Comment on attachment 330980 [details] Patch for review r=me

WebKit Commit Bot

Comment 15 2018-01-19 12:13:25 PST

Comment on attachment 330980 [details] Patch for review Clearing flags on attachment: 330980 Committed r227228: <https://trac.webkit.org/changeset/227228>

WebKit Commit Bot

Comment 16 2018-01-19 12:13:27 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.