Bug 188160

Summary: server_process.py should print returncode in debug log if the process crashed
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, ddkilzer, don.olmstead, ews-watchlist, glenn, jbedard, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 188036    
Attachments:
Description Flags
Patch
fujii.hironori: review-
Patch none

Fujii Hironori
Reported 2018-07-30 02:38:06 PDT
server_process.py should print returncode in debug log if the process crashed
Attachments
Patch (1.52 KB, patch)
2018-07-30 02:41 PDT, Fujii Hironori 		fujii.hironori: review-
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2018-07-31 06:22 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-07-30 02:41:43 PDT
Created attachment 346056 [details] Patch
Fujii Hironori
Comment 2 2018-07-30 18:17:31 PDT
Hi Jonathan, could you review this patch. You seems the best person because you did Bug 160943.
Konstantin Tokarev
Comment 3 2018-07-31 06:10:05 PDT
Comment on attachment 346056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346056&action=review > Tools/Scripts/webkitpy/port/server_process.py:326 > + _log.debug('This test marked as a crash because of failure to poll the server process. (returncode %s)' % self._proc.returncode) I think it should say 'This test marked as a crash because of failure to poll the server process (return code was %).'
Fujii Hironori
Comment 4 2018-07-31 06:19:26 PDT
Comment on attachment 346056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346056&action=review Thank you for the review. >> Tools/Scripts/webkitpy/port/server_process.py:326 >> + _log.debug('This test marked as a crash because of failure to poll the server process. (returncode %s)' % self._proc.returncode) > > I think it should say 'This test marked as a crash because of failure to poll the server process (return code was %).' Make sense. Will Fix.
Fujii Hironori
Comment 5 2018-07-31 06:22:44 PDT
Created attachment 346162 [details] Patch * Addressed the review feedback.
WebKit Commit Bot
Comment 6 2018-07-31 11:07:38 PDT
Comment on attachment 346162 [details] Patch Clearing flags on attachment: 346162 Committed r234430: <https://trac.webkit.org/changeset/234430>
WebKit Commit Bot
Comment 7 2018-07-31 11:07:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-07-31 11:12:12 PDT
<rdar://problem/42779206>
Jonathan Bedard
Comment 9 2018-08-01 09:40:27 PDT
I think this is/was a good idea, but I want to make sure that you're aware of a notable limitation: If we're controlling a device (iOS Simulator is the most notable example of this) we don't have a 'real' Popen object and can't determine what the actual return code is, in which case we will assign a returncode of 1.
Fujii Hironori
Comment 10 2018-08-01 18:27:12 PDT
Thank you for the feedback. I didn't know that. I will check it.
Note You need to log in before you can comment on or make changes to this bug.