Bug 189738

Summary: REGRESSION(r235917): 2% regression in Dromaeo CSS selector on MacBookPro11,4
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, koivisto, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 166748    
Bug Blocks:    
Attachments:
Description Flags
Fixes the bug
none
Patch for landing none

Ryosuke Niwa
Reported 2018-09-19 02:09:20 PDT
https://trac.webkit.org/changeset/235917 introduced ~27% regression in nth-child(~) tests and 2% regression for the total Dromaeo css selector tests.
Attachments
Fixes the bug (1.55 KB, patch)
2018-09-19 02:14 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.19 KB, patch)
2018-09-19 12:37 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-09-19 02:09:45 PDT
<rdar://problem/44595527>
Ryosuke Niwa
Comment 2 2018-09-19 02:14:47 PDT
Created attachment 350099 [details] Fixes the bug
Yusuke Suzuki
Comment 3 2018-09-19 02:40:26 PDT
Comment on attachment 350099 [details] Fixes the bug r=me with one more fix. I think generateNthLastChildParentCheckAndRelationUpdate has the same issue too.
Ryosuke Niwa
Comment 4 2018-09-19 12:37:31 PDT
(In reply to Yusuke Suzuki from comment #3) > Comment on attachment 350099 [details] > Fixes the bug > > r=me with one more fix. > I think generateNthLastChildParentCheckAndRelationUpdate has the same issue > too. Good catch! Thanks for the review.
Ryosuke Niwa
Comment 5 2018-09-19 12:37:52 PDT
Created attachment 350143 [details] Patch for landing
Ryosuke Niwa
Comment 6 2018-09-19 12:38:09 PDT
Comment on attachment 350143 [details] Patch for landing Wait for EWS.
Ryosuke Niwa
Comment 7 2018-09-19 15:31:20 PDT
Committed r236228: <https://trac.webkit.org/changeset/236228>
Yusuke Suzuki
Comment 8 2018-09-19 22:39:45 PDT
Nice, it seems the regression is recovered. https://perf.webkit.org/v3/#/charts?since=1536816937999&paneList=((19-31)-(19-39)-(19-36))
Note You need to log in before you can comment on or make changes to this bug.