Bug 190823

Summary: Add more tests for the Find UI
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: UI EventsAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 184297    
Attachments:
Description Flags
Patch tonikitoo: review+

Frédéric Wang (:fredw)
Reported 2018-10-23 03:18:19 PDT
Extracting from bug 184297 the tests that already pass after r224284.
Attachments
Patch (234.84 KB, patch)
2018-10-23 03:24 PDT, Frédéric Wang (:fredw) 		tonikitoo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2018-10-23 03:24:55 PDT
Created attachment 352966 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2018-10-23 06:12:17 PDT
Can someone please review this patch? It is just about adding more tests.
Frédéric Wang (:fredw)
Comment 3 2018-10-24 10:06:36 PDT
Comment on attachment 352966 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352966&action=review > LayoutTests/platform/ios/fast/scrolling/find-text-in-subframe.html:9 > + window.internals.settings.setAsyncFrameScrollingEnabled(true); This should have if (window.internals)
Antonio Gomes
Comment 4 2018-10-25 05:24:39 PDT
Comment on attachment 352966 [details] Patch r+ with your self-comment addressed.
Frédéric Wang (:fredw)
Comment 5 2018-10-25 05:46:36 PDT
Committed r237411: <https://trac.webkit.org/changeset/237411>
Radar WebKit Bug Importer
Comment 6 2018-10-25 05:47:28 PDT
<rdar://problem/45551540>
Note You need to log in before you can comment on or make changes to this bug.