Bug 198925

Summary: [iOS] Pressing key while holding Command should not insert character
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar, PlatformOnly
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 12   
Bug Depends on:    
Bug Blocks: 190571    
Attachments:
Description Flags
Patch and test none

Daniel Bates
Reported 2019-06-17 11:13:39 PDT
Seen on iOS. Steps to reproduce: 1. Visit <data:text/html,<input%20type="text">> 2. Focus the input. 3. Press Command + Shift + v. Then nothing should be inserted. But a v is inserted.
Attachments
Patch and test (5.21 KB, patch)
2019-06-17 11:30 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-06-17 11:14:14 PDT
<rdar://problem/51778811>
Daniel Bates
Comment 2 2019-06-17 11:30:30 PDT
Created attachment 372259 [details] Patch and test If I have a moment, I will look to write a more comprehensive test. Maybe I could modify the fast/events/ios/key-event-comprehensive tests. I didn't want to now since these tests already run longish and I did not want to tempt fate with a modification that could make them run even longer ... and timeout. Maybe I could duplicate these tests as an alternative.
Brent Fulgham
Comment 3 2019-06-18 08:36:37 PDT
Comment on attachment 372259 [details] Patch and test View in context: https://bugs.webkit.org/attachment.cgi?id=372259&action=review Looks reasonable. r=me. > Source/WebKit/ChangeLog:11 > + time of writing) should not insert v. This matches iOS and Mac platform conventions. Yes!
Daniel Bates
Comment 4 2019-06-18 13:59:38 PDT
Comment on attachment 372259 [details] Patch and test Clearing flags on attachment: 372259 Committed r246564: <https://trac.webkit.org/changeset/246564>
Daniel Bates
Comment 5 2019-06-18 13:59:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.