Bug 202559

Summary: [WebAuthn] Implement _WKWebAuthenticationPanel SPI
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, ggaren, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943, 191523, 200932, 202563    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jiewen Tan
Reported 2019-10-03 21:45:21 PDT
Implement _WKWebAuthenticationPanel SPI.
Attachments
Patch (83.03 KB, patch)
2019-10-03 23:42 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (83.86 KB, patch)
2019-10-04 01:31 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (84.21 KB, patch)
2019-10-04 02:08 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2019-10-03 21:45:48 PDT
<rdar://problem/55932094>
Jiewen Tan
Comment 2 2019-10-03 23:42:41 PDT
Created attachment 380191 [details] Patch
Jiewen Tan
Comment 3 2019-10-04 01:31:46 PDT
Created attachment 380196 [details] Patch
Jiewen Tan
Comment 4 2019-10-04 02:08:26 PDT
Created attachment 380201 [details] Patch
Brent Fulgham
Comment 5 2019-10-04 09:01:59 PDT
Comment on attachment 380201 [details] Patch Looks good. Thank you for writing tests!
Jiewen Tan
Comment 6 2019-10-04 09:19:31 PDT
Comment on attachment 380201 [details] Patch Thanks, Brent.
WebKit Commit Bot
Comment 7 2019-10-04 09:50:08 PDT
Comment on attachment 380201 [details] Patch Clearing flags on attachment: 380201 Committed r250729: <https://trac.webkit.org/changeset/250729>
WebKit Commit Bot
Comment 8 2019-10-04 09:50:10 PDT
All reviewed patches have been landed. Closing bug.
Jiewen Tan
Comment 9 2019-10-04 15:22:57 PDT
A build fix is landed: Committed r250751: <https://trac.webkit.org/changeset/250751>
Alex Christensen
Comment 10 2019-10-04 15:31:58 PDT
Another build fix is needed for the use of API::WebAuthenticationPanel in _WKWebAuthenticationPanelInternal.h
Alex Christensen
Comment 11 2019-10-04 15:36:47 PDT
Never mind. I think Jiewen's build fix was sufficient.
Note You need to log in before you can comment on or make changes to this bug.