Bug 203737

Summary: [JSC] OSR exit to LLInt is broken on MIPS
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ews-watchlist, guijemont, jbedard, jsc32, keith_miller, mark.lam, msaboff, rniwa, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Caio Lima
Reported 2019-11-01 07:39:43 PDT
See list of failing tests in https://bugs.webkit.org/show_bug.cgi?id=203710
Attachments
Patch (13.80 KB, patch)
2019-11-19 06:24 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (14.19 KB, patch)
2019-11-19 08:18 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Guillaume Emont
Comment 1 2019-11-08 09:23:57 PST
Skipping another failing test with similar backtrace in Bug 204003.
Caio Lima
Comment 2 2019-11-14 12:08:43 PST
New broken test: stress/ensure-code-block-is-not-precise-allocation.js.dfg-eager
Caio Lima
Comment 3 2019-11-19 06:24:34 PST
Created attachment 383862 [details] Patch
Guillaume Emont
Comment 4 2019-11-19 06:56:40 PST
Comment on attachment 383862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383862&action=review This looks like the right approach, assuming tests pass. > Source/JavaScriptCore/ChangeLog:14 > + `OFFLINE_ASM_CPLOAD` macro) immideatly after a non-local label. With typo: immediately > Source/JavaScriptCore/ChangeLog:19 > + emmit code using the correct register required to recalculate `$gp`. typo: emit
Caio Lima
Comment 5 2019-11-19 08:18:56 PST
Created attachment 383870 [details] Patch
Yusuke Suzuki
Comment 6 2019-11-19 20:01:11 PST
Comment on attachment 383870 [details] Patch r=me
Caio Lima
Comment 7 2019-11-20 12:07:02 PST
Comment on attachment 383870 [details] Patch Thank you very much for the review!
WebKit Commit Bot
Comment 8 2019-11-20 13:30:53 PST
The commit-queue encountered the following flaky tests while processing attachment 383870 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2019-11-20 13:31:02 PST
The commit-queue encountered the following flaky tests while processing attachment 383870 [details]: imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.any.html bug 204421 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2019-11-20 15:12:49 PST
Comment on attachment 383870 [details] Patch Clearing flags on attachment: 383870 Committed r252713: <https://trac.webkit.org/changeset/252713>
WebKit Commit Bot
Comment 11 2019-11-20 15:12:51 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2019-11-20 15:13:17 PST
<rdar://problem/57374650>
Note You need to log in before you can comment on or make changes to this bug.