Bug 207359

Summary:

Add slot based test for the accelerated animations freezing bug (201048)

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Animations

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, graouts, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=204805
https://bugs.webkit.org/show_bug.cgi?id=201048

Attachments:

Description	Flags
patch	none

Antti Koivisto

Reported 2020-02-06 14:50:52 PST

Fix had a simpler test case but it is good to add one for the original problem too.

Attachments
patch (3.75 KB, patch) 2020-02-06 14:58 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2020-02-06 14:58:27 PST

Created attachment 390004 [details] patch

Ryosuke Niwa

Comment 2 2020-02-06 15:02:45 PST

Comment on attachment 390004 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=390004&action=review > LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:52 > + // Put a named slot and assign an element to it. These comments seem unnecessary? I can see that from the code. > LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:60 > + // Create another named slot and assign another element to it. Ditto. > LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:64 > + // Start animation in the seconds slot. Ditto. > LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:79 > + // Wait until animation has progressed some before snapshotting the test result. Whereas this explanation is kind of useful.

Antti Koivisto

Comment 3 2020-02-06 15:10:03 PST

> These comments seem unnecessary? I can see that from the code. They were in the original test, I suppose the author found them helpful.

Ryosuke Niwa

Comment 4 2020-02-06 15:17:55 PST

(In reply to Antti Koivisto from comment #3) > > These comments seem unnecessary? I can see that from the code. > > They were in the original test, I suppose the author found them helpful. Was it imported from somewhere?? If so, we need to give a credit.

Ryosuke Niwa

Comment 5 2020-02-06 15:18:21 PST

Comment on attachment 390004 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=390004&action=review > LayoutTests/ChangeLog:10 > + Based on the original test by Tim Guan-tin Chien. Ah, I missed this line.

WebKit Commit Bot

Comment 6 2020-02-06 18:07:29 PST

Comment on attachment 390004 [details] patch Clearing flags on attachment: 390004 Committed r255996: <https://trac.webkit.org/changeset/255996>

WebKit Commit Bot

Comment 7 2020-02-06 18:07:31 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2020-02-06 18:08:13 PST

<rdar://problem/59246972>

Note You need to log in before you can comment on or make changes to this bug.