Bug 208415

Summary:

[Cocoa] Mapping from MIME type to UTI type should be done in the UI process

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebKit Misc.

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, bfulgham, commit-queue, jacob_uphoff, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=208508

Bug Depends on:

208513

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	bfulgham: review+
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Per Arne Vollan

Reported 2020-02-29 08:49:11 PST

This is currently done in the WebContent process, but since this is using a system service which will be closed, this mapping should be moved to the UI process.

Attachments
Patch (16.43 KB, patch) 2020-02-29 09:06 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (18.98 KB, patch) 2020-02-29 09:29 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (19.18 KB, patch) 2020-02-29 12:19 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (19.37 KB, patch) 2020-02-29 13:32 PST, Per Arne Vollan	bfulgham: review+	Details Formatted Diff Diff
Patch (19.71 KB, patch) 2020-02-29 15:53 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (19.92 KB, patch) 2020-03-02 10:49 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (19.92 KB, patch) 2020-03-02 11:06 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (19.97 KB, patch) 2020-03-02 16:12 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (20.02 KB, patch) 2020-03-02 17:47 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (19.14 KB, patch) 2020-03-03 07:55 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (19.21 KB, patch) 2020-03-03 08:02 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (19.53 KB, patch) 2020-03-03 10:53 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (19.55 KB, patch) 2020-03-03 12:27 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (19.49 KB, patch) 2020-03-03 14:30 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (19.66 KB, patch) 2020-03-03 16:00 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (19.62 KB, patch) 2020-03-03 17:19 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Per Arne Vollan

Comment 1 2020-02-29 09:06:14 PST

Created attachment 392062 [details] Patch

Radar WebKit Bug Importer

Comment 2 2020-02-29 09:06:47 PST

<rdar://problem/59919609>

Per Arne Vollan

Comment 3 2020-02-29 09:29:37 PST

Created attachment 392065 [details] Patch

Per Arne Vollan

Comment 4 2020-02-29 12:19:54 PST

Created attachment 392069 [details] Patch

Per Arne Vollan

Comment 5 2020-02-29 13:32:04 PST

Created attachment 392070 [details] Patch

Per Arne Vollan

Comment 6 2020-02-29 15:53:40 PST

Created attachment 392077 [details] Patch

Per Arne Vollan

Comment 7 2020-02-29 15:54:40 PST

Thanks for reviewing!

WebKit Commit Bot

Comment 8 2020-02-29 19:31:46 PST

The commit-queue encountered the following flaky tests while processing attachment 392077 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 9 2020-02-29 19:32:21 PST

Comment on attachment 392077 [details] Patch Clearing flags on attachment: 392077 Committed r257687: <https://trac.webkit.org/changeset/257687>

Jacob Uphoff

Comment 10 2020-03-02 07:40:14 PST

It looks like the changes made here have caused 50+ assertion failures between macOS and iOS. https://results.webkit.org/?suite=layout-tests&test=editing%2Fpasteboard%2Fcopy-standalone-image.html & https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fcanvas%2Fphilip%2Ftests%2Fsecurity.pattern.create.html

Jacob Uphoff

Comment 11 2020-03-02 08:13:37 PST

Reverted r257687 for reason: This commit caused debug tests to crash for macOS & iOS Committed r257713: <https://trac.webkit.org/changeset/257713>

Per Arne Vollan

Comment 12 2020-03-02 10:49:24 PST

Created attachment 392153 [details] Patch

Per Arne Vollan

Comment 13 2020-03-02 11:06:52 PST

Created attachment 392156 [details] Patch

WebKit Commit Bot

Comment 14 2020-03-02 12:21:38 PST

Comment on attachment 392156 [details] Patch Clearing flags on attachment: 392156 Committed r257725: <https://trac.webkit.org/changeset/257725>

Jacob Uphoff

Comment 15 2020-03-02 15:59:02 PST

Reverted r257725 for reason: This commit caused 10 API tests to fail Committed r257745: <https://trac.webkit.org/changeset/257745>

Per Arne Vollan

Comment 16 2020-03-02 16:12:44 PST

Created attachment 392210 [details] Patch

Per Arne Vollan

Comment 17 2020-03-02 17:47:04 PST

Created attachment 392231 [details] Patch

WebKit Commit Bot

Comment 18 2020-03-02 18:37:40 PST

Comment on attachment 392231 [details] Patch Clearing flags on attachment: 392231 Committed r257754: <https://trac.webkit.org/changeset/257754>

Aakash Jain

Comment 19 2020-03-03 05:05:21 PST

(In reply to WebKit Commit Bot from comment #18) > Committed r257754: <https://trac.webkit.org/changeset/257754> This seems to have broken API test: TestWebKitAPI.DragAndDropTests.CanStartDragOnEnormousImage, Tracked in Bug 208508. EWS also warned about this failure in https://ews-build.webkit.org/#/builders/9/builds/18618

Per Arne Vollan

Comment 20 2020-03-03 07:55:51 PST

Created attachment 392275 [details] Patch

Per Arne Vollan

Comment 21 2020-03-03 08:02:27 PST

Created attachment 392277 [details] Patch

Per Arne Vollan

Comment 22 2020-03-03 10:53:57 PST

Created attachment 392298 [details] Patch

Per Arne Vollan

Comment 23 2020-03-03 12:27:52 PST

Created attachment 392309 [details] Patch