Bug 214275

Summary:

Update WPT tests for css-text

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

Tools / Tests

Assignee:

Carlos Alberto Lopez Perez <clopez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, darin, ews-watchlist, mmaxfield, rego, simon.fraser, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=214290
https://bugs.webkit.org/show_bug.cgi?id=214414

Bug Depends on:

Bug Blocks:

213927

Attachments:

Description	Flags
test patch for EWS, ignore	none
Patch	none
Patch	none
Patch	none

Carlos Alberto Lopez Perez

Reported 2020-07-13 14:44:39 PDT

Update WPT tests for css/css-text

Attachments
test patch for EWS, ignore (3.28 MB, patch) 2020-07-13 14:47 PDT, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (3.60 MB, patch) 2020-07-13 19:24 PDT, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (3.60 MB, patch) 2020-07-14 03:37 PDT, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Patch (3.60 MB, patch) 2020-07-14 06:18 PDT, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Carlos Alberto Lopez Perez

Comment 1 2020-07-13 14:47:33 PDT

Created attachment 404177 [details] test patch for EWS, ignore

Carlos Alberto Lopez Perez

Comment 2 2020-07-13 19:24:21 PDT

Created attachment 404203 [details] Patch Hopefully all EWS will be green, let's see

Carlos Alberto Lopez Perez

Comment 3 2020-07-14 03:37:02 PDT

Created attachment 404219 [details] Patch

Carlos Alberto Lopez Perez

Comment 4 2020-07-14 04:57:42 PDT

All green. Asking for review: r?

Manuel Rego Casasnovas

Comment 5 2020-07-14 05:33:41 PDT

Comment on attachment 404219 [details] Patch Thanks.

Carlos Alberto Lopez Perez

Comment 6 2020-07-14 06:18:07 PDT

Again getting issues with the tooling.. when trying to land this manually i get -E2BIG error. $ Tools/Scripts/webkit-patch land -g HEAD Logging in as clopez@igalia.com... Fetching: https://bugs.webkit.org/show_bug.cgi?id=214275&ctype=xml&excludefield=attachmentdata Guessing "Manuel Rego Casasnovas" as reviewer from attachment 404219 [details] on bug 214275. Total errors found: 0 in 6 files COMMIT FAILED: [Errno 7] Argument list too long Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 80, in <module> main() File "Tools/Scripts/webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/steps/commit.py", line 89, in run svn_revision = scm.svn_revision_from_commit_text(commit_text) File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 106, in svn_revision_from_commit_text return match.group('svn_revision') AttributeError: 'NoneType' object has no attribute 'group' let's try commit-queue to see if that works better

Carlos Alberto Lopez Perez

Comment 7 2020-07-14 06:18:56 PDT

Created attachment 404229 [details] Patch Patch for landing

EWS

Comment 8 2020-07-14 07:06:29 PDT

Committed r264338: <https://trac.webkit.org/changeset/264338> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404229 [details].

Radar WebKit Bug Importer

Comment 9 2020-07-16 10:06:29 PDT

<rdar://problem/65673010>

Note You need to log in before you can comment on or make changes to this bug.