Bug 226333
| Summary: | [GTK4] Make favicon and snapshot API use GdkTexture instead of cairo surfaces | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alice Mikhaylenko <alicem> | 
| Component: | WebKitGTK | Assignee: | Carlos Garcia Campos <cgarcia> | 
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro, sonny | 
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 210100 | ||
          Alice Mikhaylenko
          
          
          
          
        
        
      See https://bugs.webkit.org/show_bug.cgi?id=212327#c12
>  Hm, do you think we should create a bug to change webkit_web_view_get_snapshot_finish() to return a GdkTexture rather than a cairo_surface_t? It might be nice to remove cairo from WebKit's API?
> (We'd of course want to do that in a separate bug, not here. It will be a bit hard because I think gtk-doc cannot handle conditional compilation. We will blow its little mind.)
    | Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. | 
          Carlos Garcia Campos
          
          
          
          
        
        
      Pull request: https://github.com/WebKit/WebKit/pull/9747
    
          EWS
          
          
          
          
        
        
      Committed 259997@main (d15c97f78b03): <https://commits.webkit.org/259997@main>
Reviewed commits have been landed. Closing PR #9747 and removing active labels.