Bug 227897

Summary: consider removing support for removed SVG properties
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: SVGAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, joepeck, kondapallykalyan, macpherson, menard, pdr, rbuis, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 191292    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Cameron McCormack (:heycam)
Reported 2021-07-12 23:31:33 PDT
There are four properties that were removed from the SVG 2 spec, and which are not supported in other browsers: * color-profile -- we recognize the property but don't do anything with it * color-rendering -- we parse and expose this but don't do anything else with it * glyph-orientation-horizontal -- we do use this in our SVG text layout * kerning -- we do use this too in our SVG text layout Don't see why we shouldn't remove the first two, and we should probably try to remove the second two as well. (The text-orientation and letter-spacing properties are the official replacements for glyph-orientation-horizontal and kerning.)
Attachments
Patch (17.69 KB, patch)
2021-08-08 11:27 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (47.39 KB, patch)
2021-08-08 13:24 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (112.61 KB, patch)
2021-08-08 14:16 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (112.62 KB, patch)
2021-08-08 22:43 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (112.94 KB, patch)
2021-08-09 00:35 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (115.56 KB, patch)
2021-08-09 04:57 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (117.07 KB, patch)
2021-10-18 23:46 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2021-07-12 23:42:07 PDT
Also, glyph-orientation-vertical is deprecated, but still is in the spec. But WebKit is the only engine to implement it too.
Cameron McCormack (:heycam)
Comment 2 2021-07-12 23:46:41 PDT
Relatedly, enable-background is another one that was removed (though from the Filters spec), and which we recognize but don't do anything with.
Radar WebKit Bug Importer
Comment 3 2021-07-19 23:32:16 PDT
<rdar://problem/80821560>
Rob Buis
Comment 4 2021-08-08 11:27:44 PDT
Created attachment 435149 [details] Patch
Rob Buis
Comment 5 2021-08-08 13:24:35 PDT
Created attachment 435152 [details] Patch
Rob Buis
Comment 6 2021-08-08 14:16:17 PDT
Created attachment 435157 [details] Patch
Rob Buis
Comment 7 2021-08-08 22:43:31 PDT
Created attachment 435166 [details] Patch
Rob Buis
Comment 8 2021-08-09 00:35:55 PDT
Created attachment 435173 [details] Patch
Rob Buis
Comment 9 2021-08-09 04:57:47 PDT
Created attachment 435183 [details] Patch
Rob Buis
Comment 10 2021-08-09 09:10:26 PDT
This seems reasonable to me for color-profile, color-rendering and enable-background.
Rob Buis
Comment 11 2021-10-18 06:54:08 PDT
@heycam WDYT, looks reasonable?
Cameron McCormack (:heycam)
Comment 12 2021-10-18 23:10:46 PDT
Comment on attachment 435183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435183&action=review Non-reviewer r=me. > Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:183 > // the above properties are not yet implemented in the engine "this property is not yet implemented in the engine"
Cameron McCormack (:heycam)
Comment 13 2021-10-18 23:12:01 PDT
Once this patch lands, please file a separate bug for the other properties I mentioned that we should try to remove.
Rob Buis
Comment 14 2021-10-18 23:46:38 PDT
Created attachment 441692 [details] Patch
Rob Buis
Comment 15 2021-10-19 06:03:00 PDT
(In reply to Cameron McCormack (:heycam) from comment #13) > Once this patch lands, please file a separate bug for the other properties I > mentioned that we should try to remove. Sure, I filed https://bugs.webkit.org/show_bug.cgi?id=231948 for this.
EWS
Comment 16 2021-10-19 06:40:50 PDT
Committed r284447 (243207@main): <https://commits.webkit.org/243207@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441692 [details].
Note You need to log in before you can comment on or make changes to this bug.