Bug 253202
| Summary: | [GTK] MiniBrowser needs updated for various downloads changes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=253146 | ||
Michael Catanzaro
In 261002@main we forgot to update a call to webkit_download_get_destination() in MiniBrowser that expects to receive a URI but now receives a path.
Due to this, I noticed that the downloads code is currently unreachable due to a missing g_signal_connect() now that download-started moved from WebKitWebContext to WebKitNetworkSession. Let's fix that too.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Actually this was a false alarm, because all of this code is built only for GTK 3. Downloads just are not hooked up yet at all.