Bug 270162
| Summary: | Simplify compiler flags checking in Source/ThirdParty/skia/CMakeLists.txt | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | CMake | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 268972, 270161, 270220 | ||
Adrian Perez
The CMakeLists.txt looks a bit gnarly around the checks for supported
compiler flags. There could be some helpers in WebKitCompilerFlags.cmake,
and most of the needed logic is already there but not in a way that can
be conveniently reused for the Skia build definitions.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/25169
EWS
Committed 275430@main (e739d6576a59): <https://commits.webkit.org/275430@main>
Reviewed commits have been landed. Closing PR #25169 and removing active labels.