Bug 284871
| Summary: | [CMake] Remove support for using an externally built copy of Skia | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | CMake | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 268972 | ||
| Bug Blocks: | |||
Adrian Perez
We currently support setting SKIA_ROOT_DIR in the environment pointing to a copy of the library built outside of the WebKit tree. This was useful during the initial bringup, but this has not been used for a good while. As per the FIXME in `Source/ThirdParty/skia/CMakeLists.txt`, we should remove this and support only in-tree Skia builds going forward. The `ext-skia-configure` script may be removed as well.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/39682
EWS
Committed 289495@main (ba4919dd2c05): <https://commits.webkit.org/289495@main>
Reviewed commits have been landed. Closing PR #39682 and removing active labels.