Bug 39852

Summary: [Qt] fast/encoding/yentest.html fails
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Siddharth Mathur <s.mathur>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, cshu, hamaji, hausmann, ossy, s.mathur
Priority: P3 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Bug Depends on: 60786    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Alexey Proskuryakov
Reported 2010-05-27 11:35:10 PDT
fast/encoding/yentest.html and fast/encoding/yentest2.html are new tests that fail on Qt. -two backslashes external: \ -two backslashes inline: \ +two backslashes external: ¥¥ +two backslashes inline: ¥¥
Attachments
Patch (1.10 KB, patch)
2011-05-18 12:37 PDT, Siddharth Mathur 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-05-27 11:38:19 PDT
Disabled the tests in r60314. This looks like either a Qt DRT deficiency, or a pretty bad bug that would break most JavaScript code on pages with certain Japanese encodings.
Alexey Proskuryakov
Comment 2 2010-11-18 13:06:18 PST
Or perhaps Qt just doesn't recognize charset name "shift-jis" (as opposed to canonical Shift_JIS).
Simon Hausmann
Comment 3 2011-05-16 01:22:30 PDT
This is actually difference between Qt's shift-jis codec implementation and ICU. The intention of changing this is Qt is now tracked at http://bugreports.qt.nokia.com/browse/QTBUG-19335
Siddharth Mathur
Comment 4 2011-05-18 12:37:42 PDT
Created attachment 93968 [details] Patch
Chang Shu
Comment 5 2011-05-18 12:42:54 PDT
LGTM. I also ran the tests and they are passing. :)
Siddharth Mathur
Comment 6 2011-05-18 14:10:47 PDT
Comment on attachment 93968 [details] Patch Forgot to cq? it before review. Hope this leads to a commit by the cq. :)
WebKit Review Bot
Comment 7 2011-05-18 14:11:28 PDT
Comment on attachment 93968 [details] Patch Rejecting attachment 93968 [details] from commit-queue. siddharth.mathur@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 8 2011-05-18 16:35:05 PDT
Comment on attachment 93968 [details] Patch Clearing flags on attachment: 93968 Committed r86803: <http://trac.webkit.org/changeset/86803>
WebKit Commit Bot
Comment 9 2011-05-18 16:35:10 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 10 2011-05-18 16:35:58 PDT
The commit-queue encountered the following flaky tests while processing attachment 93968 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.