Bug 40359

Summary: [Qt] Imperfect dependency for generated SVGNames.cpp
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: hausmann, jturcotte, krit
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
Patch krit: review+

Csaba Osztrogonác
Reported 2010-06-09 03:04:05 PDT
SVGNames.cpp should depends on svgattrs.in. This bug was revealed by http://trac.webkit.org/changeset/60858 Thx for it Krit, and sorry for extra roll-out and roll-in. ;) Fix is coming soon. I propose we should cherry-pick this patch into the release branch to avoid similar dependency problems on the release bot.
Attachments
Patch (1.41 KB, patch)
2010-06-09 03:07 PDT, Csaba Osztrogonác 		krit: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2010-06-09 03:07:22 PDT
Created attachment 58229 [details] Patch
Dirk Schulze
Comment 2 2010-06-09 03:11:41 PDT
Comment on attachment 58229 [details] Patch r=me
Csaba Osztrogonác
Comment 3 2010-06-09 03:27:56 PDT
(In reply to comment #2) > (From update of attachment 58229 [details]) > r=me Landed in http://trac.webkit.org/changeset/60887
Simon Hausmann
Comment 4 2010-06-10 03:24:59 PDT
<cherry-pick-for-backport: r60887>
Simon Hausmann
Comment 5 2010-06-10 03:26:02 PDT
Revision r60887 cherry-picked into qtwebkit-2.0 with commit ee767532772e25137a68239af074e979204dcee1
Note You need to log in before you can comment on or make changes to this bug.