Bug 48093

Summary: EWS does not need to process obsolete patches
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, ojan, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 35460    
Attachments:
Description Flags
wip
none
Patch none

Eric Seidel (no email)
Reported 2010-10-21 15:01:06 PDT
EWS does not need to process obsolete patches
Attachments
wip (1.53 KB, patch)
2010-10-21 15:02 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (18.53 KB, patch)
2010-10-22 12:47 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-10-21 15:02:34 PDT
Created attachment 71499 [details] wip
Eric Seidel (no email)
Comment 2 2010-10-22 12:47:46 PDT
Created attachment 71585 [details] Patch
Adam Barth
Comment 3 2010-10-22 12:56:00 PDT
Comment on attachment 71585 [details] Patch Hum... Feels like a big testing tax.
Eric Seidel (no email)
Comment 4 2010-10-22 13:03:03 PDT
I'm not sure what you mean. Are you suggesting that our shared fixtures are a burden? I would agree they are, but the problem is that if we don't use them then we get in to the problems that this patch fixes: of having one part of the code look at one fixture while another looks at different one. Using shared fixtures throughout makes this problem go away, but does cause our tests to be tightly coupled and make changing those central fixures more painful.
Adam Barth
Comment 5 2010-10-22 13:08:23 PDT
I just meant that the ratio of code change to test change was really out of whack in this patch. I think you're improving things so that will be less the case going forward, but we need to watch this stuff to make sure new code and new tests won't have the same problem.
WebKit Commit Bot
Comment 6 2010-10-22 13:19:32 PDT
Comment on attachment 71585 [details] Patch Clearing flags on attachment: 71585 Committed r70328: <http://trac.webkit.org/changeset/70328>
WebKit Commit Bot
Comment 7 2010-10-22 13:19:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.