Bug 49080

Summary: webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on:    
Bug Blocks: 48166    
Attachments:
Description Flags
Patch
aroben: review-
Patch none

Dimitri Glazkov (Google)
Reported 2010-11-05 11:24:41 PDT
The output is like this: WebKitTools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl ............ ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl ......... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl .............. Dubious, test returned 25 (wstat 6400, 0x1900) Failed 8/16 subtests List form of pipe open not implemented at D:/google-windows-2/chromium-win-release-tests/build/WebKitTools/Scripts/VCSUtils.pm line 1579. # Looks like you planned 16 tests but ran 8. # Looks like your test exited with 25 just after 8. WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl .................... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl .............. ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl ........... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl ................... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl ........... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl ........... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl ............. ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl ........ ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl ........... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl .................... ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl .............. ok WebKitTools/Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl .. ok Test Summary Report ------------------- WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl (Wstat: 6400 Tests: 8 Failed: 0) Non-zero exit status: 25 Parse errors: Bad plan. You planned 16 tests but ran 8. Files=15, Tests=301, 2 wallclock secs ( 0.09 usr + 0.02 sys = 0.11 CPU) Result: FAIL Failed 1/15 test programs. 0/301 subtests failed.
Attachments
Patch (1.17 KB, patch)
2011-08-23 11:08 PDT, Patrick R. Gansterer 		aroben: review-
DetailsFormatted DiffDiff
Patch (1.18 KB, patch)
2011-08-23 11:19 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-08-23 11:08:40 PDT
Created attachment 104868 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-08-23 11:11:19 PDT
Comment on attachment 104868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104868&action=review > Tools/Scripts/VCSUtils.pm:1699 > - open(DIFF, "-|", qw(diff -u -a --binary), $fileOlder, $fileMine) or die $!; > + open(DIFF, "diff -u -a --binary $fileOlder $fileMine |") or die $!; You now need to quote $fileOlder and $fileMine in case they contain spaces.
Patrick R. Gansterer
Comment 3 2011-08-23 11:15:58 PDT
Comment on attachment 104868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104868&action=review >> Tools/Scripts/VCSUtils.pm:1699 >> + open(DIFF, "diff -u -a --binary $fileOlder $fileMine |") or die $!; > > You now need to quote $fileOlder and $fileMine in case they contain spaces. We don't do correct escaping on different places. e.g. only 8 lines down: http://trac.webkit.org/browser/trunk/Tools/Scripts/VCSUtils.pm#L1707
Adam Roben (:aroben)
Comment 4 2011-08-23 11:18:05 PDT
Comment on attachment 104868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104868&action=review >>> Tools/Scripts/VCSUtils.pm:1699 >>> + open(DIFF, "diff -u -a --binary $fileOlder $fileMine |") or die $!; >> >> You now need to quote $fileOlder and $fileMine in case they contain spaces. > > We don't do correct escaping on different places. e.g. only 8 lines down: http://trac.webkit.org/browser/trunk/Tools/Scripts/VCSUtils.pm#L1707 We should fix those places (separately). We want WebKit scripts to work regardless of the path to your checkout.
Patrick R. Gansterer
Comment 5 2011-08-23 11:19:42 PDT
Created attachment 104872 [details] Patch
WebKit Review Bot
Comment 6 2011-08-23 12:27:46 PDT
Comment on attachment 104872 [details] Patch Clearing flags on attachment: 104872 Committed r93623: <http://trac.webkit.org/changeset/93623>
WebKit Review Bot
Comment 7 2011-08-23 12:27:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.