Bug 58459

Summary: Exclude webkitGetUserMedia from the navigator-detached-no-crash test
Product: WebKit Reporter: Leandro Graciá Gil <leandrogracia>
Component: Tools / TestsAssignee: Leandro Graciá Gil <leandrogracia>
Status: RESOLVED FIXED    
Severity: Normal CC: jianli, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 56586    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch
none
Patch
none
Patch jianli: review+, jianli: commit-queue-

Leandro Graciá Gil
Reported 2011-04-13 11:09:20 PDT
Exclude the webkitGetUserMedia method from the test until it is supported by most platforms. Once this happens, the expected behaviour for this method is to throw an exception when invoked with no arguments.
Attachments
Patch (2.00 KB, patch)
2011-04-13 11:15 PDT, Leandro Graciá Gil 		no flags
DetailsFormatted DiffDiff
Patch (2.24 KB, patch)
2011-04-13 11:35 PDT, Leandro Graciá Gil 		no flags
DetailsFormatted DiffDiff
Patch (1.93 KB, patch)
2011-04-13 11:45 PDT, Leandro Graciá Gil 		jianli: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Leandro Graciá Gil
Comment 1 2011-04-13 11:15:15 PDT
Created attachment 89408 [details] Patch
Jian Li
Comment 2 2011-04-13 11:25:30 PDT
Comment on attachment 89408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89408&action=review > LayoutTests/fast/dom/navigator-detached-no-crash.html:56 > + if (p != 'webkitGetUserMedia') { // Don't include the Media Stream API functions until most platforms have support. Can you combine this logic with the existing check for "geolocation" into some common check? Maybe you can keep an excluding list and check this list in for loop.
Leandro Graciá Gil
Comment 3 2011-04-13 11:35:32 PDT
Created attachment 89412 [details] Patch
Leandro Graciá Gil
Comment 4 2011-04-13 11:35:52 PDT
Comment on attachment 89408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89408&action=review >> LayoutTests/fast/dom/navigator-detached-no-crash.html:56 >> + if (p != 'webkitGetUserMedia') { // Don't include the Media Stream API functions until most platforms have support. > > Can you combine this logic with the existing check for "geolocation" into some common check? Maybe you can keep an excluding list and check this list in for loop. Fixed.
Jian Li
Comment 5 2011-04-13 11:41:46 PDT
Comment on attachment 89412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89412&action=review > LayoutTests/fast/dom/navigator-detached-no-crash.html:55 > + if (p != 'geolocation' && p != 'webkitGetUserMedia') { // Don't include Geolocation or the Media Stream API functions until most platforms have support. Better to use early return, like: if (p == 'geolocation' || p == 'webkitGetUserMedia') //... continue; ...
Leandro Graciá Gil
Comment 6 2011-04-13 11:45:18 PDT
Created attachment 89417 [details] Patch
Leandro Graciá Gil
Comment 7 2011-04-13 11:45:34 PDT
Comment on attachment 89412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89412&action=review >> LayoutTests/fast/dom/navigator-detached-no-crash.html:55 >> + if (p != 'geolocation' && p != 'webkitGetUserMedia') { // Don't include Geolocation or the Media Stream API functions until most platforms have support. > > Better to use early return, like: > if (p == 'geolocation' || p == 'webkitGetUserMedia') //... > continue; > ... Fixed.
Jian Li
Comment 8 2011-04-13 12:09:28 PDT
Committed as https://trac.webkit.org/changeset/83754.
Note You need to log in before you can comment on or make changes to this bug.