Bug 59456

Summary: audio-no-installed-engines.html media test has unnecessary pixel results
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dbates, eric, mitz, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch.
adele: review-, adele: commit-queue-
Updated patch none

Eric Carlson
Reported 2011-04-26 07:45:19 PDT
It appears that audio-no-installed-engines.html has always had pixel results, but it succeeds if the browser does not crash so dumpAsText results would be better.
Attachments
Proposed patch. (5.38 KB, patch)
2011-04-26 07:52 PDT, Eric Carlson 		adele: review-
adele: commit-queue-
DetailsFormatted DiffDiff
Updated patch (5.58 KB, patch)
2011-04-27 08:23 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2011-04-26 07:52:23 PDT
Created attachment 91107 [details] Proposed patch.
mitz
Comment 2 2011-04-26 08:20:50 PDT
DumpRenderTree always waits until the document is loaded, so I'm not sure why you need to wait until done, only to call notifyDone immediately in the load event handler. Also, you're missing the new, text-only result in the patch.
Adele Peterson
Comment 3 2011-04-26 16:50:57 PDT
Comment on attachment 91107 [details] Proposed patch. r- based on Dan's comments.
Eric Carlson
Comment 4 2011-04-27 08:22:06 PDT
(In reply to comment #2) > DumpRenderTree always waits until the document is loaded, so I'm not sure why you need to > wait until done, only to call notifyDone immediately in the load event handler. I did this to make sure that the audio element allows 'load' to fire once it enters the error state, but we already have tests explicitly for this so I removed it from this patch. > Also, you're missing the new, text-only result in the patch. Oops!
Eric Carlson
Comment 5 2011-04-27 08:23:06 PDT
Created attachment 91283 [details] Updated patch
WebKit Commit Bot
Comment 6 2011-04-27 20:34:09 PDT
The commit-queue encountered the following flaky tests while processing attachment 91283 [details]: http/tests/websocket/tests/workers/worker-simple.html bug 59669 (author: abarth@webkit.org) http/tests/xmlhttprequest/simple-cross-origin-progress-events.html bug 54798 (authors: ap@webkit.org and levin@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2011-04-27 20:35:32 PDT
Comment on attachment 91283 [details] Updated patch Clearing flags on attachment: 91283 Committed r85144: <http://trac.webkit.org/changeset/85144>
WebKit Commit Bot
Comment 8 2011-04-27 20:35:37 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 9 2011-04-27 21:16:56 PDT
http://trac.webkit.org/changeset/85144 might have broken WinCE Release (Build)
Note You need to log in before you can comment on or make changes to this bug.