Bug 60517

Summary: [Chromium] Add rebaseline images for video-controls-rendering.
Product: WebKit Reporter: imasaki
Component: New BugsAssignee: imasaki
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jianli, levin, vrk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

imasaki
Reported 2011-05-09 16:47:19 PDT
[Chromium] Add rebaseline images for video-controls-rendering.
Attachments
Patch (472.26 KB, patch)
2011-05-09 16:48 PDT, imasaki 		no flags
DetailsFormatted DiffDiff
Patch (472.34 KB, patch)
2011-05-09 17:02 PDT, imasaki 		no flags
DetailsFormatted DiffDiff
Patch (472.58 KB, patch)
2011-05-09 17:50 PDT, imasaki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
imasaki
Comment 1 2011-05-09 16:48:24 PDT
Created attachment 92885 [details] Patch
imasaki
Comment 2 2011-05-09 17:02:23 PDT
Created attachment 92887 [details] Patch
David Levin
Comment 3 2011-05-09 17:42:49 PDT
Comment on attachment 92887 [details] Patch The ChangeLog really doesn't provide enough information here. It points to this bug http://code.google.com/p/chromium/issues/detail?id=74102 but that bug isn't fixed. Are we checking in a bad baseline so that we ensure no other problems occur (while bug 74102 is being fixed)? This information would be helpful in the ChangeLog. (In general the ChangeLog should explain why this change is being done.)
imasaki
Comment 4 2011-05-09 17:50:46 PDT
Created attachment 92895 [details] Patch
WebKit Commit Bot
Comment 5 2011-05-09 18:52:39 PDT
The commit-queue encountered the following flaky tests while processing attachment 92895 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-05-09 18:56:13 PDT
Comment on attachment 92895 [details] Patch Clearing flags on attachment: 92895 Committed r86121: <http://trac.webkit.org/changeset/86121>
WebKit Commit Bot
Comment 7 2011-05-09 18:56:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.