Bug 74102

Summary: Use bitfield for bool data members in BitmapImage.
Product: WebKit Reporter: Yongjun Zhang <yongjun_zhang>
Component: WebCore Misc.Assignee: Yongjun Zhang <yongjun_zhang>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, yongjun_zhang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Use bitfield for bool data members in BitmapImage and FrameData.
webkit-ews: commit-queue-
Fix style issue.
webkit-ews: commit-queue-
Take 3, fix Qt build breakage.
darin: review+
Fix minor style issue, adding space around the colons. none

Yongjun Zhang
Reported 2011-12-08 10:19:32 PST
We can reduce the memory footprint of BitmapImage by using bitfield for its bool data members.
Attachments
Use bitfield for bool data members in BitmapImage and FrameData. (5.28 KB, patch)
2011-12-08 10:38 PST, Yongjun Zhang 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Fix style issue. (5.04 KB, patch)
2011-12-08 10:57 PST, Yongjun Zhang 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Take 3, fix Qt build breakage. (7.58 KB, patch)
2011-12-08 12:24 PST, Yongjun Zhang 		darin: review+
DetailsFormatted DiffDiff
Fix minor style issue, adding space around the colons. (7.60 KB, patch)
2011-12-08 14:04 PST, Yongjun Zhang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yongjun Zhang
Comment 1 2011-12-08 10:38:48 PST
Created attachment 118418 [details] Use bitfield for bool data members in BitmapImage and FrameData.
WebKit Review Bot
Comment 2 2011-12-08 10:41:30 PST
Attachment 118418 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/BitmapImage.h:283: One space before end of line comments [whitespace/comments] [5] Source/WebCore/platform/graphics/BitmapImage.h:286: One space before end of line comments [whitespace/comments] [5] Source/WebCore/platform/graphics/BitmapImage.h:288: One space before end of line comments [whitespace/comments] [5] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2011-12-08 10:42:45 PST
Comment on attachment 118418 [details] Use bitfield for bool data members in BitmapImage and FrameData. Attachment 118418 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10809306
Yongjun Zhang
Comment 4 2011-12-08 10:57:14 PST
Created attachment 118422 [details] Fix style issue.
Early Warning System Bot
Comment 5 2011-12-08 11:13:35 PST
Comment on attachment 118422 [details] Fix style issue. Attachment 118422 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10797312
Yongjun Zhang
Comment 6 2011-12-08 12:24:02 PST
Created attachment 118447 [details] Take 3, fix Qt build breakage.
Darin Adler
Comment 7 2011-12-08 13:14:58 PST
Comment on attachment 118447 [details] Take 3, fix Qt build breakage. View in context: https://bugs.webkit.org/attachment.cgi?id=118447&action=review > Source/WebCore/platform/graphics/BitmapImage.h:92 > + bool m_haveMetadata:1; > + bool m_isComplete:1; > + bool m_hasAlpha:1; Our normal style is to put spaces around the colons.
Yongjun Zhang
Comment 8 2011-12-08 14:04:27 PST
Created attachment 118465 [details] Fix minor style issue, adding space around the colons.
WebKit Review Bot
Comment 9 2011-12-08 17:31:27 PST
Comment on attachment 118465 [details] Fix minor style issue, adding space around the colons. Clearing flags on attachment: 118465 Committed r102404: <http://trac.webkit.org/changeset/102404>
WebKit Review Bot
Comment 10 2011-12-08 17:31:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.