Bug 75915

Summary: CSS transitions should work on the flex property
Product: WebKit Reporter: Tony Chang <tony>
Component: Layout and RenderingAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, hyatt, morrita, ojan, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch
none
Patch none

Tony Chang
Reported 2012-01-09 17:09:53 PST
It should be possible to transition from flex() to flex() or from a length to flex() or from flex() to length.
Attachments
Patch (9.53 KB, patch)
2012-02-03 17:02 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (7.84 KB, patch)
2012-04-04 13:49 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-02-03 17:02:40 PST
Created attachment 125449 [details] Patch
Hajime Morrita
Comment 2 2012-02-20 20:58:47 PST
It looks the test compares the value as a number (float), not a tuple of the numbers. Is it intentional? (Disclaimer: I'm not a flexbox expert.)
Tony Chang
Comment 3 2012-02-21 13:51:49 PST
Comment on attachment 125449 [details] Patch The spec is changing so this patch isn't correct anymore. I'll post a new patch when we're ready.
Tony Chang
Comment 4 2012-04-04 13:49:27 PDT
Created attachment 135668 [details] Patch
Ojan Vafai
Comment 5 2012-04-04 14:31:27 PDT
Patch looks good to me. Someone with transitions experience should probably r+ though.
Dean Jackson
Comment 6 2012-04-04 15:50:26 PDT
Comment on attachment 135668 [details] Patch Cool!
WebKit Review Bot
Comment 7 2012-04-04 16:57:51 PDT
Comment on attachment 135668 [details] Patch Clearing flags on attachment: 135668 Committed r113264: <http://trac.webkit.org/changeset/113264>
WebKit Review Bot
Comment 8 2012-04-04 16:57:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.