Bug 77954

Summary: MediaStream API: Add the onstatechange callback to PeerConnection
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch none

Tommy Widenflycht
Reported 2012-02-07 02:37:48 PST
The current implementation is missing the onstatechange callback. Note that the patch doesn't contain iceState or sdpState, that will be added when the dust settles regarding ROAP/JSEP in the standard.
Attachments
Patch (5.21 KB, patch)
2012-02-07 02:42 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-02-07 02:42:10 PST
Created attachment 125796 [details] Patch
Adam Barth
Comment 2 2012-02-07 10:38:48 PST
Comment on attachment 125796 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125796&action=review > Source/WebCore/ChangeLog:10 > + Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code. How close are we to being able to write these tests? It feels like we've got a lot of this code landed now.
Tommy Widenflycht
Comment 3 2012-02-08 00:54:49 PST
Comment on attachment 125796 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125796&action=review >> Source/WebCore/ChangeLog:10 >> + Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code. > > How close are we to being able to write these tests? It feels like we've got a lot of this code landed now. Expect the first rough patch later this week :) Agree that it is long overdue...
Adam Barth
Comment 4 2012-02-08 00:59:07 PST
> Expect the first rough patch later this week :) Yay!
WebKit Review Bot
Comment 5 2012-02-08 01:52:37 PST
Comment on attachment 125796 [details] Patch Clearing flags on attachment: 125796 Committed r107054: <http://trac.webkit.org/changeset/107054>
WebKit Review Bot
Comment 6 2012-02-08 01:52:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.