Bug 78773

Summary: MediaStream API: enhance the implementaion of MediaStreamTrack::setEnabled
Product: WebKit Reporter: William Lin <wei.a.lin>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, tommyw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

William Lin
Reported 2012-02-15 19:27:02 PST
in current implementaion of MediaStreamTrack::setEnabled, whether or no the MediaStream is live, the track enable/disable setting operation will be called via didSetMediaStreamTrackEnabled(). Actually, if MediaStream is finished, above operation can be ignored. please notice, the status of MediaStreamTrack can be set regardless of MediaStream' status.
Attachments
Patch (1.33 KB, patch)
2012-02-15 19:44 PST, William Lin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
William Lin
Comment 1 2012-02-15 19:44:48 PST
Created attachment 127299 [details] Patch add a patch for review
Adam Barth
Comment 2 2012-02-20 19:44:08 PST
@tommyw: Thoughts on this patch? Ideally we would test this change as well. Tommy is working on a test framework for this code, which might be helpful. @lin: Please mark your patches "review?" when you'd like them reviewed. That makes the show up in all the appropriate queues. Thanks for the patch.
Tommy Widenflycht
Comment 3 2012-02-21 00:44:50 PST
The patch looks like a reasonable thing to do. And fyi, I'll be sending out two more patches for the test framework later today.
Adam Barth
Comment 4 2012-02-21 10:51:45 PST
Comment on attachment 127299 [details] Patch I'm tempted to say we should hold off on this patch until the testing framework lands, but I don't want to hold your change hostage. Hopefully we'll get Tommy the necessary reviews for the testing framework shortly and we'll have it ready for your future patches.
WebKit Review Bot
Comment 5 2012-02-21 12:08:29 PST
The commit-queue encountered the following flaky tests while processing attachment 127299 [details]: storage/indexeddb/index-basics.html bug 79138 (authors: dgrogan@chromium.org and jsbell@chromium.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 6 2012-02-21 12:10:36 PST
Comment on attachment 127299 [details] Patch Clearing flags on attachment: 127299 Committed r108383: <http://trac.webkit.org/changeset/108383>
WebKit Review Bot
Comment 7 2012-02-21 12:10:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.