Bug 79114

Summary: MediaStream API: Adding a mock for PeerConnectionHandler
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED WONTFIX    
Severity: Normal CC: commit-queue, fishd, harald
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459, 56587    
Attachments:
Description Flags
Patch
none
Patch none

Tommy Widenflycht
Reported 2012-02-21 08:36:44 PST
Adding a mock for PeerConnectionHandler together with the chromium embedders. No actual LayoutTests since the plumbing needs to be done in chromium first.
Attachments
Patch (35.44 KB, patch)
2012-02-21 08:46 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (35.43 KB, patch)
2012-02-23 03:34 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-02-21 08:46:28 PST
Created attachment 127980 [details] Patch
Adam Barth
Comment 2 2012-02-22 18:01:26 PST
Comment on attachment 127980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127980&action=review > Source/WebCore/mediastream/PeerConnection.h:56 > + // Name and values of the enum must match the corressponding constants in the PeerConnection.idl file. Presumably the compiler enforces this with a COMPILE_ASSERT. > Source/WebKit/chromium/src/WebPeerConnectionHandlerMock.cpp:56 > +WebPeerConnectionHandlerMock:: ~WebPeerConnectionHandlerMock() Extra space after the ::
Tommy Widenflycht
Comment 3 2012-02-23 03:33:02 PST
Comment on attachment 127980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127980&action=review >> Source/WebCore/mediastream/PeerConnection.h:56 >> + // Name and values of the enum must match the corressponding constants in the PeerConnection.idl file. > > Presumably the compiler enforces this with a COMPILE_ASSERT. You're right so I removed the comment. >> Source/WebKit/chromium/src/WebPeerConnectionHandlerMock.cpp:56 >> +WebPeerConnectionHandlerMock:: ~WebPeerConnectionHandlerMock() > > Extra space after the :: Fixed.
Tommy Widenflycht
Comment 4 2012-02-23 03:34:25 PST
Created attachment 128450 [details] Patch
WebKit Commit Bot
Comment 5 2012-02-24 01:44:17 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Darin Fisher (:fishd, Google)
Comment 6 2012-02-24 10:59:30 PST
Comment on attachment 128450 [details] Patch Why are mocks part of WebCore / WebKit and not just part of DumpRenderTree?
Note You need to log in before you can comment on or make changes to this bug.