Bug 79476

Summary: Refactor EventHandler::handleGestureEvent
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: UI EventsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 78801    
Attachments:
Description Flags
Patch none

Allan Sandfeld Jensen
Reported 2012-02-24 04:57:27 PST
The handling of specific gesture events should be moved out of the switch statement in handleGestureEvent. Especially since they will become more complicated as the issues in them are resolved. Additionally the two gesture events tap and scrollupdate events could return better return-values even is the return value is not currently used.
Attachments
Patch (6.36 KB, patch)
2012-02-24 05:00 PST, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-02-24 05:00:07 PST
Created attachment 128711 [details] Patch
WebKit Review Bot
Comment 2 2012-02-24 07:00:58 PST
The commit-queue encountered the following flaky tests while processing attachment 128711 [details]: storage/indexeddb/index-basics.html bug 79138 (authors: dgrogan@chromium.org and jsbell@chromium.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 3 2012-02-24 07:03:04 PST
Comment on attachment 128711 [details] Patch Clearing flags on attachment: 128711 Committed r108793: <http://trac.webkit.org/changeset/108793>
WebKit Review Bot
Comment 4 2012-02-24 07:03:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.