Bug 81333

Summary: MediaStream API (JSEP): Introducing PeerConnection00Handler
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: harald, pkasting, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 81377    
Bug Blocks: 80589    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Tommy Widenflycht
Reported 2012-03-16 04:47:35 PDT
In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.
Attachments
Patch (14.12 KB, patch)
2012-03-16 04:52 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (14.12 KB, patch)
2012-03-16 06:13 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (14.10 KB, patch)
2012-03-16 07:08 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (14.12 KB, patch)
2012-03-19 06:56 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-03-16 04:52:29 PDT
Created attachment 132251 [details] Patch
Tommy Widenflycht
Comment 2 2012-03-16 06:13:19 PDT
Created attachment 132266 [details] Patch
Adam Barth
Comment 3 2012-03-16 06:50:04 PDT
Comment on attachment 132266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132266&action=review > Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp:65 > +PassRefPtr<SessionDescriptionDescriptor> PeerConnection00Handler::createAnswer(const String& offer, PassRefPtr<MediaHints>) You might need to add UNUSED_PARAM(offer) for some ports.
Tommy Widenflycht
Comment 4 2012-03-16 06:58:00 PDT
Comment on attachment 132266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132266&action=review >> Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp:65 >> +PassRefPtr<SessionDescriptionDescriptor> PeerConnection00Handler::createAnswer(const String& offer, PassRefPtr<MediaHints>) > > You might need to add UNUSED_PARAM(offer) for some ports. I'll just remove all argument names , these are just dummy implementations after all. OK?
Tommy Widenflycht
Comment 5 2012-03-16 07:08:38 PDT
Created attachment 132276 [details] Patch
WebKit Review Bot
Comment 6 2012-03-16 09:57:19 PDT
Comment on attachment 132276 [details] Patch Clearing flags on attachment: 132276 Committed r111020: <http://trac.webkit.org/changeset/111020>
WebKit Review Bot
Comment 7 2012-03-16 09:57:23 PDT
All reviewed patches have been landed. Closing bug.
Peter Kasting
Comment 8 2012-03-16 11:21:19 PDT
This broke Chromium Win compile: http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/24486/steps/compile-webkit/logs/stdio tommyw and abarth don't seem to be around, I plan to roll out and reopen.
Peter Kasting
Comment 9 2012-03-16 11:34:05 PDT
Rolled out in r111035.
Tommy Widenflycht
Comment 10 2012-03-19 06:56:18 PDT
Created attachment 132570 [details] Patch
Tommy Widenflycht
Comment 11 2012-03-19 06:58:55 PDT
Hopefully fixed build break by adding the necessary headers to Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp Strange that all other compilers optimized away the unused references, but windows failed.
Adam Barth
Comment 12 2012-03-19 11:10:23 PDT
Comment on attachment 132570 [details] Patch Ok.
WebKit Review Bot
Comment 13 2012-03-19 11:33:38 PDT
Comment on attachment 132570 [details] Patch Clearing flags on attachment: 132570 Committed r111208: <http://trac.webkit.org/changeset/111208>
WebKit Review Bot
Comment 14 2012-03-19 11:33:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.