Bug 81377

Summary:

REGRESSION(r111020): Broke Chromium Win compile (Requested by pkasting on #webkit).

Product:

WebKit

Reporter:

WebKit Review Bot <webkit.review.bot>

Component:

New Bugs

Assignee:

WebKit Review Bot <webkit.review.bot>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, pkasting, tommyw

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

81333

Attachments:

Description	Flags
ROLLOUT of r111020	none

WebKit Review Bot

Reported 2012-03-16 11:25:39 PDT

http://trac.webkit.org/changeset/111020 broke the build: Broke Chromium Win compile (Requested by pkasting on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear

Attachments
ROLLOUT of r111020 (12.88 KB, patch) 2012-03-16 11:26 PDT, WebKit Review Bot	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

WebKit Review Bot

Comment 1 2012-03-16 11:26:14 PDT

Created attachment 132327 [details] ROLLOUT of r111020 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.

Peter Kasting

Comment 2 2012-03-16 11:33:28 PDT

Comment on attachment 132327 [details] ROLLOUT of r111020 Clearing flags on attachment: 132327 Committed r111035: <http://trac.webkit.org/changeset/111035>

Peter Kasting

Comment 3 2012-03-16 11:33:33 PDT

All reviewed patches have been landed. Closing bug.

Adam Barth

Comment 4 2012-03-16 13:03:03 PDT

Peter, do you have a link to the compile error?

Adam Barth

Comment 5 2012-03-16 13:05:05 PDT

7>e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(52) : error C2027: use of undefined type 'WebCore::MediaHints' 7> e:\b\chromium-win-release-tests\build\source\webcore\platform\mediastream\PeerConnection00Handler.h(45) : see declaration of 'WebCore::MediaHints' 7> e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(67) : see reference to function template instantiation 'void WTF::derefIfNotNull<T>(T *)' being compiled 7> with 7> [ 7> T=WebCore::MediaHints 7> ] 7> e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(67) : while compiling class template member function 'WTF::PassRefPtr<T>::~PassRefPtr(void)' 7> with 7> [ 7> T=WebCore::MediaHints 7> ] 7> ..\platform\mediastream\PeerConnection00Handler.cpp(61) : see reference to class template instantiation 'WTF::PassRefPtr<T>' being compiled 7> with 7> [ 7> T=WebCore::MediaHints 7> ] 7>e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(52) : error C2227: left of '->deref' must point to class/struct/union/generic type 7>e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(52) : error C2027: use of undefined type 'WebCore::IceOptions' 7> e:\b\chromium-win-release-tests\build\source\webcore\platform\mediastream\PeerConnection00Handler.h(44) : see declaration of 'WebCore::IceOptions' 7> e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(67) : see reference to function template instantiation 'void WTF::derefIfNotNull<T>(T *)' being compiled 7> with 7> [ 7> T=WebCore::IceOptions 7> ] 7> e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(67) : while compiling class template member function 'WTF::PassRefPtr<T>::~PassRefPtr(void)' 7> with 7> [ 7> T=WebCore::IceOptions 7> ] 7> ..\platform\mediastream\PeerConnection00Handler.cpp(91) : see reference to class template instantiation 'WTF::PassRefPtr<T>' being compiled 7> with 7> [ 7> T=WebCore::IceOptions 7> ] 7>e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(52) : error C2227: left of '->deref' must point to class/struct/union/generic type

Adam Barth

Comment 6 2012-03-16 13:05:19 PDT

Found it: http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/24492/steps/compile-webkit/logs/stdio Thanks!

Note You need to log in before you can comment on or make changes to this bug.